Julenmendieta/removeTelegram#30
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a changeset file to track the removal of 'telegram' functionality. The reviewer noted that the PR lacks the corresponding code changes and suggested updating the versioning from 'patch' to 'minor' to better reflect the nature of the change, providing a code suggestion for the version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR removes Telegram CI notifications from the
mark-stableworkflow and replaces them with Slack notifications, matching the pattern already used inbuild.yaml. A changeset entry is also added to record a patch bump across all rarefaction packages.notify-telegram: trueand the two Telegram secrets (TELEGRAM_NOTIFICATION_TARGET,TELEGRAM_API_TOKEN) from.github/workflows/mark-stable.yaml, replacing them withSLACK_BOT_TOKENandSLACK_CHANNEL— bringing this workflow in line withbuild.yaml.Confidence Score: 5/5
Safe to merge — the change swaps two Telegram secrets for two Slack secrets in a manually-triggered workflow, mirroring the notification setup already live in build.yaml.
Both changed files are straightforward: the workflow change is a direct like-for-like substitution of notification secrets, and the changeset file correctly documents all affected packages. No logic, build steps, or publishing behavior is altered.
No files require special attention.
Important Files Changed
Sequence Diagram
sequenceDiagram participant GHA as GitHub Actions participant WF as block-mark-stable.yaml@v4 participant Slack as Slack (SLACK_BOT_TOKEN) GHA->>WF: workflow_dispatch trigger WF->>WF: build / mark stable WF->>Slack: post notification to SLACK_BLOCKS_CI_CHANNEL Note over WF,Slack: Previously sent to Telegram (TG_CHANNEL_MIBUILDS)<br/>Now uses Slack — consistent with build.yamlReviews (1): Last reviewed commit: "Changeset" | Re-trigger Greptile