Update repository references and migration instructions#297
Update repository references and migration instructions#297akalipetis wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates repository references from platformsh/cli to upsun/cli across configuration files, installer script, and README, and adds migration warnings to guide users to the new repository.
Changes:
- Updated GitHub repository and Homebrew tap references in configuration files (
upsun-cli.yaml,platformsh-cli.yaml) - Modified installer script to use new repository URLs and added interactive migration warning with user prompt
- Updated README with prominent migration notice and installer URL references
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/config/upsun-cli.yaml | Updated homebrew_tap and github_repo to reference upsun organization |
| internal/config/platformsh-cli.yaml | Updated homebrew_tap and github_repo to reference upsun organization |
| installer.sh | Updated download URLs to upsun/cli; added migration warning system with interactive prompt, skip flag, and helper functions |
| README.md | Added migration notice at top; updated all installer URLs and download links to reference new repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| # Read from /dev/tty to get input even when script is piped | ||
| read -r -p " Do you want to continue with this installer? [y/N] " response < /dev/tty |
There was a problem hiding this comment.
@miguelsanchez-upsun I didn't get this prompt when calling this script with
curl https://raw.githubusercontent.com/platformsh/cli/e5b2eb06e3826d97ba318500084a1345ac6851ab/installer.sh | bashin iTerm2 on macOS
it just continues with the installation
but also... do we need to redirect the user in this case? when we could instead modify the script to install the new package (but preserving the same vendor behavior as before)
| output_stderr "" | ||
| output_stderr "\033[33m+-------------------------------------------------------------------------------------+\033[0m" | ||
| output_stderr "\033[33m| |\033[0m" | ||
| output_stderr "\033[33m| WARNING: This repository (platformsh/cli) has been migrated to upsun/cli |\033[0m" |
There was a problem hiding this comment.
Update migration instructions to inform users about the repository change to
upsun/cli. Update Homebrew tap and GitHub repository references in configuration files and scripts to reflect the new repository. Add a warning in the installer script to guide users towards the new installation method.