Full senior audit + Phase 0 Critical/High fixes - #18
Merged
Conversation
Document a full senior audit with phased remediation tasks, then land Phase 0 fixes: CacheRefresher reentrancy, Room 5→6 tags migration, SyncWorker typed outcomes, transaction date/cache/offline filters, money/date form validation, and issue-report/log sanitization. Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
Record PASS WITH NOTES results for tasks C1, C2, H1, H2, U1, and S1. Co-authored-by: Gerben Jongerius <gjong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performed a full senior-developer audit of the Android codebase (security, architecture, data layer, UI/tests) and documented findings in
docs/audit/SENIOR_AUDIT_2026-07-28.md.Phase 0 (stop-the-bleeding) fixes from that backlog are included. Each task was implemented by a senior developer agent and reviewed by a senior QA agent.
MIGRATION_5_6missingtagstagsto match schema v6; regression testResult.retry()on transient failuresQA write-ups:
docs/audit/qa/TASK-*-QA-REVIEW.md.Remaining High/Medium/Low items are tasked in the audit doc for follow-up phases (session expiry nav, outbox idempotency, opening balance, localization, Actions SHA pinning, etc.).
Test plan
./gradlew clean testDebugUnitTest --no-daemon./gradlew lintDebug --no-daemon./gradlew assembleDebug --no-daemon(optional smoke)