fix: skip hk hooks in the release job - #18
Merged
Conversation
`mise install` runs the postinstall hook, which runs `hk install --mise` and points core.hooksPath at hk. hk's hooks then fire on the commits and pushes changesets/action makes. pre-push cannot resolve the tag objects `changeset publish` pushes: it looks for a merge base against origin/main, and an annotated tag is not a commit, so it aborts with "object is no commit object" and takes the tag push down with it. That published 0.3.0/0.1.2 to npm but left the tags and GitHub releases uncreated. Re-running the job could not repair it either, since changesets/action only tags what `changeset publish` reports as newly published. Those two tags and releases were created by hand. Skipping pre-commit alongside it: re-running lint/check/test in the release job only repeats what CI already ran on the pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mise installruns the postinstall hook, which runshk install --miseand points core.hooksPath at hk. hk's hooks then fire on the commits and pushes changesets/action makes.pre-push cannot resolve the tag objects
changeset publishpushes: it looks for a merge base against origin/main, and an annotated tag is not a commit, so it aborts with "object is no commit object" and takes the tag push down with it. That published 0.3.0/0.1.2 to npm but left the tags and GitHub releases uncreated.Re-running the job could not repair it either, since changesets/action only tags what
changeset publishreports as newly published. Those two tags and releases were created by hand.Skipping pre-commit alongside it: re-running lint/check/test in the release job only repeats what CI already ran on the pull request.