fix(ci): correct MSRV toolchain pin and coverage artifact upload inputs - #189
Merged
Merged
Conversation
MSRV job installed dtolnay/rust-toolchain@1.100 (nonexistent Rust version) instead of @1.75, and the coverage job passed Codecov-shaped inputs (files/fail_ci_if_error) to actions/upload-artifact, which needs name/path. Both jobs failed on every push to main as a result. Filed by the Polyhook/steplock production-readiness audit routine. Fixes #188.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtolnay/rust-toolchain@1.100(Rust 1.100 doesn't exist) instead of@1.75, matching the job name andcore/Cargo.toml'srust-version = "1.75".files/fail_ci_if_error) toactions/upload-artifact@v7, which needsname/path— the upload step failed with "Input required and not supplied: path".Both jobs failed on every push to
main; the underlying code, tests, and coverage generation were fine.Fixes #188.
Test plan
MSRV (1.75)andCode coverage (cargo-llvm-cov)jobs passing.Filed and opened by the "Polyhook/steplock production-readiness audit → PR + Slack" moadim routine.