fix: select from values error - #1165
Open
KnorpelSenf wants to merge 1 commit into
Open
Conversation
Author
|
What can I do to get this merged? |
|
I also have this problem, would be great to have it merged! 😄 |
|
Same here. This makes working with more complex CTEs really difficult |
Author
|
@olee have you already tested this in your project? Perhaps another external review helps convince the admins to smash that merge button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When taking value arrays, we should test if there are multiple rows passed to
sql, not if the first row contains multiple elements. Otherwise we only catch 2D arrays but not arrays of objects.Fixes #1073.
This fixes the issue in my project but I did not take the time to set up a local postgres instance in order to run the tests. Please review carefully, this code is pretty dense and I had less time for this fix than I wish I had.