Migrate hover, signature help, and completions to ArkFile#1264
Open
lionel- wants to merge 1 commit into
Open
Conversation
…letion to `ArkFile`
lionel-
changed the title
DocumentContext and migrate hover and completions to ArkFileArkFile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1263
Progress towards #1212
The handlers migrated use a slightly different approach because they use
r_task()heavily and the Oak DB shouldn't be touched from anr_task()because of the risk of cancellation panics, which would be UB over the R stack. We could catch panics inr_task()and unwind for cancellation but I didn't want to think through the various implications.DocumentContextdropsDocumentand stores the pieces it needs from theArkDband LSP state (tree,contents,line_index,encoding). This way the DB is not sent over anr_task().Add LSP <> TS position/range converters as methods on
DocumentContext(parallel to the ones onArkFile, also replacements for theDocumentmethods).Migrate hover, signature help, and completion to the refactored
DocumentContext.