fix(bedrock): honor generic AWS_ENDPOINT_URL env var - #423
Open
cpsievert wants to merge 1 commit into
Open
Conversation
The service-specific override (AWS_ENDPOINT_URL_BEDROCK_RUNTIME / AWS_ENDPOINT_URL_BEDROCK_MANTLE) outranks the generic AWS_ENDPOINT_URL, which outranks the regional endpoint computed from the region. Closes #415
cpsievert
force-pushed
the
fix-bedrock-endpoint-env-var
branch
from
September 4, 2026 00:52
c559441 to
b293a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #415.
Most of the issue was already addressed by #406, which defaults the Bedrock
base_urlfromAWS_ENDPOINT_URL_BEDROCK_RUNTIME/AWS_ENDPOINT_URL_BEDROCK_MANTLE. This PR closes the remaining gap called out in the issue: the genericAWS_ENDPOINT_URLis now honored too, with botocore-style precedence — service-specific variable > genericAWS_ENDPOINT_URL> computed regional endpoint.Adds unit tests covering the generic var for both converse and mantle, and service-specific-outranks-generic precedence.