Skip to content

sign: Consolidate make_hint and pack_sig_h_poly #1028

Open
mkannwischer wants to merge 1 commit intomainfrom
consolidate-make-pack-hint
Open

sign: Consolidate make_hint and pack_sig_h_poly #1028
mkannwischer wants to merge 1 commit intomainfrom
consolidate-make-pack-hint

Conversation

@mkannwischer
Copy link
Copy Markdown
Contributor

@mkannwischer mkannwischer commented Apr 8, 2026 •
edited
Loading

Replace mld_poly_make_hint + mld_pack_sig_h_poly with a single
mld_make_pack_sig_h_poly that takes (a0, a1) directly, computes hint
bits via mld_make_hint, writes hint indices into sig in one pass, and
returns the updated running tally. The function returns MLD_ERR_FAIL
if the number of hints would exceed MLDSA_OMEGA.

This removes the duplicated hint counting (previously make_hint
returned the count and pack iterated the hint poly again without
re-validating) and drops the temporary scratch hint polynomial from
the sign.c hint loop.

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-87)

Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2253s 2375s -5.1%
polyvecl_pointwise_acc_montgomery_c ✅ 280s 345s -19%
polyvec_matrix_expand ✅ 193s 169s +14%
sign_verify_internal ✅ 146s 253s -42%
rej_uniform_native ✅ 127s 126s +1%
poly_pointwise_montgomery_c ✅ 103s 92s +12%
mld_invntt_layer ✅ 96s 90s +7%
mld_ct_memcmp ✅ 85s 73s +16%
mld_attempt_signature_generation ✅ 69s 62s +11%
polyvec_matrix_expand_serial ✅ 49s 56s -12%
mld_ntt_layer ✅ 46s 45s +2%
sign_keypair_internal ✅ 46s 52s -12%
sign_signature_internal ✅ 42s 36s +17%
sign_pk_from_sk ✅ 34s 34s +0%
fqmul ✅ 28s 27s +4%
polyvec_matrix_pointwise_montgomery ✅ 25s 29s -14%
polyvec_matrix_pointwise_montgomery_yvec ✅ 22s 19s +16%
keccakf1600x4_permute_native ✅ 21s 23s -9%
rej_uniform_c ✅ 19s 17s +12%
mld_ntt_butterfly_block ✅ 18s 16s +12%
rej_uniform ✅ 18s 19s -5%
poly_uniform_eta_4x ✅ 16s 13s +23%
polyt0_unpack ✅ 15s 17s -12%
poly_chknorm_c ✅ 14s 16s -12%
polyveck_use_hint ✅ 14s 11s +27%
poly_add ✅ 13s 12s +8%
polyveck_decompose ✅ 13s 12s +8%
polyvecl_chknorm ✅ 13s 4s +225%
poly_uniform_4x ✅ 12s 12s +0%
polyveck_pointwise_poly_montgomery ✅ 12s 9s +33%
mld_check_pct ✅ 11s 9s +22%
mld_compute_pack_z ✅ 11s 8s +38%
poly_power2round ✅ 11s 9s +22%
polyeta_unpack ✅ 11s 12s -8%
polyveck_caddq ✅ 11s 4s +175%
keccak_absorb_once_x4 ✅ 10s 9s +11%
mld_sample_s1_s2_serial ✅ 10s 8s +25%
polyveck_reduce ✅ 10s 7s +43%
sign ✅ 10s 7s +43%
polyveck_add ✅ 9s 11s -18%
polyveck_chknorm ✅ 9s 7s +29%
polyveck_invntt_tomont ✅ 9s 5s +80%
keccakf1600_permute ✅ 8s 7s +14%
poly_invntt_tomont_c ✅ 8s 8s +0%
polyveck_ntt ✅ 8s 10s -20%
polyveck_power2round ✅ 8s 34s -76%
keccakf1600_permute_native ✅ 7s 7s +0%
polyveck_sub ✅ 7s 8s -12%
polyvecl_ntt ✅ 7s 5s +40%
keccak_absorb ✅ 6s 7s -14%
mld_sample_s1_s2 ✅ 6s 6s +0%
pointwise_acc_native_aarch64 ✅ 6s 5s +20%
pointwise_acc_native_x86_64 ✅ 6s 8s -25%
poly_caddq_c ✅ 6s 4s +50%
poly_uniform_gamma1_4x ✅ 6s 5s +20%
polyeta_pack ✅ 6s 3s +100%
polyveck_pack_t0 ✅ 6s 3s +100%
polyz_unpack_c ✅ 6s 7s -14%
shake128x4_squeezeblocks ✅ 6s 2s +200%
sign_signature_pre_hash_shake256 ✅ 6s 8s -25%
unpack_sig ✅ 6s 4s +50%
unpack_sk ✅ 6s 6s +0%
pack_sk_rho_key_tr_s2_t0 ✅ 5s 5s +0%
poly_chknorm_native_aarch64 ✅ 5s 3s +67%
poly_decompose_c ✅ 5s 5s +0%
poly_decompose_native ✅ 5s 2s +150%
poly_reduce ✅ 5s 2s +150%
poly_uniform_eta ✅ 5s 4s +25%
poly_use_hint_c ✅ 5s 6s -17%
polyvec_matrix_pointwise_montgomery_row ✅ 5s 1s +400%
polyveck_shiftl ✅ 5s 8s -38%
rej_eta_native ✅ 5s 6s -17%
shake256x4_squeezeblocks ✅ 5s 3s +67%
sign_signature ✅ 5s 2s +150%
sign_verify_extmu ✅ 5s 4s +25%
sys_check_capability ✅ 5s 5s +0%
unpack_hints ✅ 5s 7s -29%
unpack_pk ✅ 5s 3s +67%
unpack_sk_s1hat ✅ 5s 5s +0%
keccak_f1600_x1_native_aarch64_v84a ✅ 4s 3s +33%
keccakf1600_extract_bytes (big endian) ✅ 4s 4s +0%
mld_polymat_expand_entry ✅ 4s 5s -20%
mld_prepare_domain_separation_prefix ✅ 4s 3s +33%
nttunpack_native_x86_64 ✅ 4s 3s +33%
pack_sig_z ✅ 4s 4s +0%
poly_caddq_native_aarch64 ✅ 4s 4s +0%
poly_chknorm ✅ 4s 2s +100%
poly_chknorm_native ✅ 4s 2s +100%
poly_permute_bitrev_to_custom_optional ✅ 4s 2s +100%
poly_pointwise_montgomery ✅ 4s 3s +33%
poly_pointwise_montgomery_native ✅ 4s 3s +33%
poly_use_hint_native ✅ 4s 4s +0%
polyt0_pack ✅ 4s 1s +300%
polyvecl_pointwise_acc_montgomery ✅ 4s 3s +33%
polyvecl_uniform_gamma1 ✅ 4s 3s +33%
reduce32 ✅ 4s 4s +0%
sign_verify ✅ 4s 5s -20%
sign_verify_pre_hash_shake256 ✅ 4s 2s +100%
sk_t0hat_get_poly ✅ 4s 4s +0%
yvec_init ✅ 4s 4s +0%
caddq ✅ 3s 6s -50%
intt_native_x86_64 ✅ 3s 2s +50%
keccak_f1600_x4_native_aarch64_v84a ✅ 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 3s 3s +0%
keccak_finalize ✅ 3s 2s +50%
keccak_init ✅ 3s 3s +0%
keccak_squeezeblocks_x4 ✅ 3s 4s -25%
keccakf1600x4_xor_bytes ✅ 3s 2s +50%
make_pack_sig_h_poly ✅ 3s - new
mld_ct_cmask_neg_i32 ✅ 3s 1s +200%
mld_ct_cmask_nonzero_u32 ✅ 3s 3s +0%
mld_value_barrier_u8 ✅ 3s 1s +200%
montgomery_reduce ✅ 3s 2s +50%
ntt_native_aarch64 ✅ 3s 2s +50%
ntt_native_x86_64 ✅ 3s 2s +50%
pack_pk ✅ 3s 6s -50%
pointwise_native_aarch64 ✅ 3s 2s +50%
poly_caddq ✅ 3s 2s +50%
poly_caddq_native ✅ 3s 4s -25%
poly_challenge ✅ 3s 3s +0%
poly_decompose ✅ 3s 5s -40%
poly_ntt ✅ 3s 3s +0%
poly_ntt_native ✅ 3s 3s +0%
poly_permute_bitrev_to_custom_optional_native ✅ 3s 2s +50%
poly_shiftl ✅ 3s 3s +0%
poly_uniform ✅ 3s 4s -25%
poly_use_hint ✅ 3s 2s +50%
polyt1_pack ✅ 3s 3s +0%
polyveck_pack_eta ✅ 3s 2s +50%
polyvecl_pointwise_acc_montgomery_native ✅ 3s 3s +0%
polyvecl_unpack_eta ✅ 3s 3s +0%
polyw1_pack ✅ 3s 2s +50%
polyz_pack ✅ 3s 4s -25%
polyz_unpack_native ✅ 3s 2s +50%
power2round ✅ 3s 2s +50%
rej_eta ✅ 3s 3s +0%
rej_eta_c ✅ 3s 4s -25%
shake128_absorb ✅ 3s 2s +50%
shake256 ✅ 3s 4s -25%
shake256_finalize ✅ 3s 2s +50%
shake256_init ✅ 3s 3s +0%
sign_keypair ✅ 3s 4s -25%
sign_open ✅ 3s 4s -25%
sign_signature_extmu ✅ 3s 6s -50%
sign_verify_pre_hash_internal ✅ 3s 5s -40%
sk_s1hat_get_poly ✅ 3s 5s -40%
unpack_sk_s2hat ✅ 3s 3s +0%
yvec_get_poly ✅ 3s 2s +50%
decompose ✅ 2s 3s -33%
fqscale ✅ 2s 5s -60%
keccak_f1600_x1_native_aarch64 ✅ 2s 2s +0%
keccak_f1600_x4_native_avx2 ✅ 2s 3s -33%
keccak_squeeze ✅ 2s 3s -33%
keccakf1600_xor_bytes ✅ 2s 1s +100%
keccakf1600_xor_bytes (big endian) ✅ 2s 2s +0%
keccakf1600x4_extract_bytes ✅ 2s 2s +0%
keccakf1600x4_permute ✅ 2s 2s +0%
make_hint ✅ 2s 4s -50%
mld_ct_abs_i32 ✅ 2s 3s -33%
mld_ct_get_optblocker_i64 ✅ 2s 5s -60%
mld_ct_get_optblocker_u32 ✅ 2s 2s +0%
mld_ct_get_optblocker_u8 ✅ 2s 2s +0%
mld_h ✅ 2s 4s -50%
mld_keccakf1600_extract_bytes ✅ 2s 1s +100%
pack_sig_c ✅ 2s 3s -33%
pack_sk_s1 ✅ 2s 5s -60%
pointwise_native_x86_64 ✅ 2s 5s -60%
poly_invntt_tomont ✅ 2s 4s -50%
poly_invntt_tomont_native ✅ 2s 4s -50%
poly_ntt_c ✅ 2s 2s +0%
poly_sub ✅ 2s 2s +0%
poly_use_hint_native_aarch64 ✅ 2s 2s +0%
polyt1_unpack ✅ 2s 2s +0%
polyveck_pack_w1 ✅ 2s 4s -50%
polyveck_unpack_eta ✅ 2s 3s -33%
polyveck_unpack_t0 ✅ 2s 4s -50%
polyvecl_pack_eta ✅ 2s 2s +0%
polyvecl_uniform_gamma1_serial ✅ 2s 3s -33%
polyvecl_unpack_z ✅ 2s 2s +0%
polyz_unpack ✅ 2s 3s -33%
polyz_unpack_17_native_aarch64 ✅ 2s 4s -50%
polyz_unpack_19_native_aarch64 ✅ 2s 3s -33%
shake128_finalize ✅ 2s 2s +0%
shake128_init ✅ 2s 3s -33%
shake128_release ✅ 2s 2s +0%
shake128_squeeze ✅ 2s 4s -50%
shake256_absorb ✅ 2s 2s +0%
shake256_squeeze ✅ 2s 1s +100%
shake256x4_absorb_once ✅ 2s 2s +0%
sign_signature_pre_hash_internal ✅ 2s 4s -50%
sk_s2hat_get_poly ✅ 2s 3s -33%
unpack_sk_t0hat ✅ 2s 4s -50%
use_hint ✅ 2s 4s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 1s 3s -67%
mld_ct_cmask_nonzero_u8 ✅ 1s 3s -67%
mld_ct_sel_int32 ✅ 1s 3s -67%
mld_value_barrier_i64 ✅ 1s 2s -50%
mld_value_barrier_u32 ✅ 1s 1s +0%
poly_uniform_gamma1 ✅ 1s 6s -83%
shake128x4_absorb_once ✅ 1s 3s -67%
shake256_release ✅ 1s 4s -75%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-44)

⚠️ Attention Required

Proof Status Current Previous Change
polyvec_matrix_pointwise_montgomery_yvec ⚠️ 20s 12s +67%
polyvecl_pointwise_acc_montgomery_c ⚠️ 501s 138s +263%
Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2110s 1843s +14.5%
polyvecl_pointwise_acc_montgomery_c ⚠️ 501s 138s +263%
sign_verify_internal ✅ 157s 211s -26%
rej_uniform_native ✅ 120s 130s -8%
poly_pointwise_montgomery_c ✅ 94s 107s -12%
mld_invntt_layer ✅ 91s 100s -9%
mld_ct_memcmp ✅ 77s 85s -9%
mld_attempt_signature_generation ✅ 50s 48s +4%
mld_ntt_layer ✅ 42s 45s -7%
polyvec_matrix_expand ✅ 36s 27s +33%
fqmul ✅ 26s 31s -16%
sign_keypair_internal ✅ 25s 22s +14%
keccakf1600x4_permute_native ✅ 24s 22s +9%
sign_pk_from_sk ✅ 22s 19s +16%
polyvec_matrix_pointwise_montgomery_yvec ⚠️ 20s 12s +67%
sign_signature_internal ✅ 19s 14s +36%
rej_uniform_c ✅ 18s 18s +0%
polyt0_unpack ✅ 17s 14s +21%
polyvec_matrix_pointwise_montgomery ✅ 17s 25s -32%
poly_chknorm_c ✅ 16s 17s -6%
rej_uniform ✅ 16s 17s -6%
mld_ntt_butterfly_block ✅ 14s 16s -12%
poly_uniform_4x ✅ 13s 12s +8%
poly_uniform_eta_4x ✅ 13s 15s -13%
polyeta_unpack ✅ 13s 12s +8%
poly_add ✅ 12s 11s +9%
polyz_unpack_c ✅ 12s 13s -8%
keccak_absorb_once_x4 ✅ 10s 8s +25%
polyveck_chknorm ✅ 10s 20s -50%
polyveck_decompose ✅ 10s 6s +67%
polyveck_pointwise_poly_montgomery ✅ 10s 7s +43%
mld_check_pct ✅ 9s 9s +0%
polyvec_matrix_expand_serial ✅ 9s 5s +80%
polyveck_use_hint ✅ 9s 8s +12%
keccakf1600_permute ✅ 8s 7s +14%
poly_invntt_tomont_c ✅ 8s 9s -11%
keccak_absorb ✅ 7s 6s +17%
keccakf1600_permute_native ✅ 7s 6s +17%
poly_power2round ✅ 7s 9s -22%
sign_open ✅ 7s 6s +17%
mld_prepare_domain_separation_prefix ✅ 6s 2s +200%
pointwise_acc_native_x86_64 ✅ 6s 5s +20%
polyt0_pack ✅ 6s 3s +100%
polyveck_add ✅ 6s 5s +20%
polyveck_power2round ✅ 6s 4s +50%
polyveck_reduce ✅ 6s 5s +20%
polyvecl_chknorm ✅ 6s 5s +20%
rej_eta_native ✅ 6s 2s +200%
intt_native_x86_64 ✅ 5s 4s +25%
keccak_squeezeblocks_x4 ✅ 5s 3s +67%
mld_compute_pack_z ✅ 5s 6s -17%
mld_ct_get_optblocker_i64 ✅ 5s 2s +150%
mld_sample_s1_s2 ✅ 5s 5s +0%
mld_value_barrier_u32 ✅ 5s 2s +150%
pack_sk_rho_key_tr_s2_t0 ✅ 5s 3s +67%
pack_sk_s1 ✅ 5s 4s +25%
poly_chknorm_native ✅ 5s 3s +67%
poly_decompose_c ✅ 5s 4s +25%
poly_decompose_native ✅ 5s 1s +400%
poly_pointwise_montgomery_native ✅ 5s 3s +67%
poly_sub ✅ 5s 2s +150%
polyveck_ntt ✅ 5s 4s +25%
polyvecl_pointwise_acc_montgomery ✅ 5s 2s +150%
polyvecl_pointwise_acc_montgomery_native ✅ 5s 3s +67%
shake256_absorb ✅ 5s 3s +67%
sign ✅ 5s 6s -17%
sign_signature_extmu ✅ 5s 2s +150%
sign_verify_pre_hash_internal ✅ 5s 6s -17%
unpack_sig ✅ 5s 4s +25%
caddq ✅ 4s 3s +33%
keccakf1600_extract_bytes (big endian) ✅ 4s 2s +100%
ntt_native_x86_64 ✅ 4s 3s +33%
pack_sig_z ✅ 4s 4s +0%
pointwise_acc_native_aarch64 ✅ 4s 4s +0%
pointwise_native_x86_64 ✅ 4s 3s +33%
poly_caddq ✅ 4s 3s +33%
poly_caddq_native ✅ 4s 4s +0%
poly_caddq_native_aarch64 ✅ 4s 2s +100%
poly_challenge ✅ 4s 3s +33%
poly_permute_bitrev_to_custom_optional_native ✅ 4s 2s +100%
poly_uniform_gamma1_4x ✅ 4s 4s +0%
poly_use_hint_c ✅ 4s 4s +0%
poly_use_hint_native_aarch64 ✅ 4s 2s +100%
polyveck_caddq ✅ 4s 3s +33%
polyveck_invntt_tomont ✅ 4s 6s -33%
polyveck_pack_eta ✅ 4s 4s +0%
polyveck_shiftl ✅ 4s 3s +33%
polyveck_sub ✅ 4s 5s -20%
polyvecl_ntt ✅ 4s 5s -20%
polyvecl_pack_eta ✅ 4s 7s -43%
polyz_pack ✅ 4s 3s +33%
polyz_unpack ✅ 4s 2s +100%
polyz_unpack_17_native_aarch64 ✅ 4s 4s +0%
shake128_squeeze ✅ 4s 1s +300%
shake128x4_absorb_once ✅ 4s 3s +33%
shake256 ✅ 4s 2s +100%
shake256_init ✅ 4s 4s +0%
shake256_release ✅ 4s 2s +100%
shake256_squeeze ✅ 4s 2s +100%
shake256x4_squeezeblocks ✅ 4s 3s +33%
sign_keypair ✅ 4s 3s +33%
sign_signature ✅ 4s 6s -33%
sign_signature_pre_hash_internal ✅ 4s 5s -20%
sign_signature_pre_hash_shake256 ✅ 4s 6s -33%
sign_verify_pre_hash_shake256 ✅ 4s 3s +33%
unpack_pk ✅ 4s 5s -20%
yvec_get_poly ✅ 4s 3s +33%
yvec_init ✅ 4s 5s -20%
decompose ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64 ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64_v84a ✅ 3s 3s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 3s 2s +50%
keccak_init ✅ 3s 1s +200%
keccak_squeeze ✅ 3s 4s -25%
keccakf1600_xor_bytes ✅ 3s 2s +50%
mld_ct_sel_int32 ✅ 3s 4s -25%
mld_keccakf1600_extract_bytes ✅ 3s 3s +0%
mld_value_barrier_u8 ✅ 3s 3s +0%
montgomery_reduce ✅ 3s 6s -50%
ntt_native_aarch64 ✅ 3s 4s -25%
pointwise_native_aarch64 ✅ 3s 2s +50%
poly_caddq_c ✅ 3s 4s -25%
poly_chknorm_native_aarch64 ✅ 3s 3s +0%
poly_decompose ✅ 3s 2s +50%
poly_invntt_tomont_native ✅ 3s 2s +50%
poly_ntt ✅ 3s 3s +0%
poly_ntt_c ✅ 3s 3s +0%
poly_permute_bitrev_to_custom_optional ✅ 3s 3s +0%
poly_pointwise_montgomery ✅ 3s 2s +50%
poly_reduce ✅ 3s 3s +0%
poly_shiftl ✅ 3s 5s -40%
poly_uniform ✅ 3s 4s -25%
poly_uniform_eta ✅ 3s 2s +50%
poly_uniform_gamma1 ✅ 3s 4s -25%
polyeta_pack ✅ 3s 4s -25%
polyveck_pack_t0 ✅ 3s 5s -40%
polyveck_pack_w1 ✅ 3s 4s -25%
polyveck_unpack_eta ✅ 3s 5s -40%
polyveck_unpack_t0 ✅ 3s 4s -25%
polyvecl_uniform_gamma1 ✅ 3s 3s +0%
polyvecl_uniform_gamma1_serial ✅ 3s 2s +50%
reduce32 ✅ 3s 2s +50%
rej_eta_c ✅ 3s 3s +0%
shake128_absorb ✅ 3s 3s +0%
sign_verify_extmu ✅ 3s 4s -25%
sk_s1hat_get_poly ✅ 3s 2s +50%
sk_s2hat_get_poly ✅ 3s 3s +0%
sk_t0hat_get_poly ✅ 3s 4s -25%
unpack_hints ✅ 3s 5s -40%
unpack_sk_s1hat ✅ 3s 3s +0%
unpack_sk_s2hat ✅ 3s 3s +0%
unpack_sk_t0hat ✅ 3s 5s -40%
fqscale ✅ 2s 5s -60%
keccak_f1600_x4_native_avx2 ✅ 2s 3s -33%
keccak_finalize ✅ 2s 3s -33%
keccakf1600_xor_bytes (big endian) ✅ 2s 3s -33%
keccakf1600x4_extract_bytes ✅ 2s 3s -33%
keccakf1600x4_permute ✅ 2s 3s -33%
make_hint ✅ 2s 3s -33%
make_pack_sig_h_poly ✅ 2s - new
mld_ct_abs_i32 ✅ 2s 3s -33%
mld_ct_cmask_neg_i32 ✅ 2s 2s +0%
mld_ct_cmask_nonzero_u32 ✅ 2s 3s -33%
mld_ct_get_optblocker_u32 ✅ 2s 4s -50%
mld_ct_get_optblocker_u8 ✅ 2s 1s +100%
mld_h ✅ 2s 5s -60%
mld_polymat_expand_entry ✅ 2s 4s -50%
mld_sample_s1_s2_serial ✅ 2s 3s -33%
nttunpack_native_x86_64 ✅ 2s 5s -60%
pack_pk ✅ 2s 4s -50%
pack_sig_c ✅ 2s 3s -33%
poly_chknorm ✅ 2s 4s -50%
poly_ntt_native ✅ 2s 4s -50%
poly_use_hint ✅ 2s 2s +0%
poly_use_hint_native ✅ 2s 3s -33%
polyt1_pack ✅ 2s 9s -78%
polyt1_unpack ✅ 2s 2s +0%
polyvec_matrix_pointwise_montgomery_row ✅ 2s 3s -33%
polyvecl_unpack_eta ✅ 2s 3s -33%
polyvecl_unpack_z ✅ 2s 4s -50%
polyw1_pack ✅ 2s 3s -33%
polyz_unpack_19_native_aarch64 ✅ 2s 3s -33%
polyz_unpack_native ✅ 2s 2s +0%
power2round ✅ 2s 7s -71%
rej_eta ✅ 2s 2s +0%
shake128_finalize ✅ 2s 4s -50%
shake128_init ✅ 2s 3s -33%
shake128_release ✅ 2s 2s +0%
shake128x4_squeezeblocks ✅ 2s 1s +100%
shake256_finalize ✅ 2s 3s -33%
sign_verify ✅ 2s 6s -67%
sys_check_capability ✅ 2s 6s -67%
unpack_sk ✅ 2s 4s -50%
use_hint ✅ 2s 3s -33%
keccak_f1600_x4_native_aarch64_v84a ✅ 1s 3s -67%
keccakf1600x4_xor_bytes ✅ 1s 6s -83%
mld_ct_cmask_nonzero_u8 ✅ 1s 3s -67%
mld_value_barrier_i64 ✅ 1s 4s -75%
poly_invntt_tomont ✅ 1s 4s -75%
shake256x4_absorb_once ✅ 1s 4s -75%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof Status Current Previous Change
polyvec_matrix_pointwise_montgomery ⚠️ 43s 23s +87%
Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2032s 2488s -18.3%
polyvecl_pointwise_acc_montgomery_c ✅ 226s 622s -64%
rej_uniform_native ✅ 131s 136s -4%
sign_verify_internal ✅ 118s 125s -6%
polyvec_matrix_expand ✅ 111s 137s -19%
poly_pointwise_montgomery_c ✅ 110s 109s +1%
mld_invntt_layer ✅ 99s 104s -5%
mld_ct_memcmp ✅ 83s 86s -3%
mld_attempt_signature_generation ✅ 45s 54s -17%
mld_ntt_layer ✅ 44s 48s -8%
polyvec_matrix_pointwise_montgomery ⚠️ 43s 23s +87%
sign_keypair_internal ✅ 37s 31s +19%
fqmul ✅ 31s 33s -6%
sign_signature_internal ✅ 28s 33s -15%
sign_pk_from_sk ✅ 26s 20s +30%
polyvec_matrix_expand_serial ✅ 25s 30s -17%
keccakf1600x4_permute_native ✅ 22s 22s +0%
polyvec_matrix_pointwise_montgomery_yvec ✅ 22s 21s +5%
rej_uniform_c ✅ 19s 19s +0%
mld_ntt_butterfly_block ✅ 18s 18s +0%
poly_chknorm_c ✅ 16s 17s -6%
rej_uniform ✅ 16s 20s -20%
mld_check_pct ✅ 15s 10s +50%
polyt0_unpack ✅ 15s 16s -6%
polyveck_power2round ✅ 15s 18s -17%
poly_uniform_eta_4x ✅ 13s 14s -7%
polyveck_decompose ✅ 13s 17s -24%
poly_add ✅ 12s 12s +0%
poly_uniform_4x ✅ 12s 13s -8%
polyveck_add ✅ 11s 12s -8%
polyveck_use_hint ✅ 11s 10s +10%
keccak_absorb_once_x4 ✅ 10s 11s -9%
poly_power2round ✅ 10s 10s +0%
polyveck_caddq ✅ 10s 7s +43%
polyveck_sub ✅ 10s 9s +11%
keccakf1600_permute ✅ 9s 8s +12%
pointwise_acc_native_aarch64 ✅ 9s 7s +29%
poly_invntt_tomont_c ✅ 9s 10s -10%
polyveck_invntt_tomont ✅ 9s 8s +12%
mld_compute_pack_z ✅ 8s 9s -11%
pointwise_acc_native_x86_64 ✅ 8s 7s +14%
polyveck_pointwise_poly_montgomery ✅ 8s 8s +0%
polyveck_reduce ✅ 8s 7s +14%
sign ✅ 8s 9s -11%
keccak_absorb ✅ 7s 9s -22%
keccakf1600_permute_native ✅ 7s 6s +17%
mld_prepare_domain_separation_prefix ✅ 7s 6s +17%
polyvecl_ntt ✅ 7s 9s -22%
pack_sig_z ✅ 6s 5s +20%
poly_decompose_c ✅ 6s 4s +50%
polyveck_chknorm ✅ 6s 5s +20%
polyveck_ntt ✅ 6s 6s +0%
polyveck_shiftl ✅ 6s 9s -33%
polyvecl_chknorm ✅ 6s 9s -33%
polyvecl_pack_eta ✅ 6s 5s +20%
polyz_unpack_19_native_aarch64 ✅ 6s 2s +200%
sign_verify_pre_hash_internal ✅ 6s 7s -14%
sys_check_capability ✅ 6s 3s +100%
make_hint ✅ 5s 4s +25%
nttunpack_native_x86_64 ✅ 5s 4s +25%
pack_pk ✅ 5s 2s +150%
pointwise_native_x86_64 ✅ 5s 2s +150%
poly_caddq_native ✅ 5s 3s +67%
poly_challenge ✅ 5s 3s +67%
poly_invntt_tomont_native ✅ 5s 3s +67%
poly_uniform ✅ 5s 4s +25%
poly_uniform_eta ✅ 5s 3s +67%
poly_use_hint_native ✅ 5s 2s +150%
polyeta_unpack ✅ 5s 3s +67%
polyt0_pack ✅ 5s 5s +0%
polyveck_pack_t0 ✅ 5s 4s +25%
polyveck_pack_w1 ✅ 5s 4s +25%
polyveck_unpack_eta ✅ 5s 4s +25%
polyvecl_pointwise_acc_montgomery_native ✅ 5s 6s -17%
polyvecl_uniform_gamma1_serial ✅ 5s 3s +67%
power2round ✅ 5s 2s +150%
unpack_hints ✅ 5s 7s -29%
unpack_sk_s2hat ✅ 5s 3s +67%
decompose ✅ 4s 6s -33%
fqscale ✅ 4s 2s +100%
keccak_squeezeblocks_x4 ✅ 4s 6s -33%
keccakf1600_xor_bytes (big endian) ✅ 4s 2s +100%
keccakf1600x4_permute ✅ 4s 1s +300%
make_pack_sig_h_poly ✅ 4s - new
mld_h ✅ 4s 2s +100%
mld_sample_s1_s2_serial ✅ 4s 7s -43%
ntt_native_x86_64 ✅ 4s 3s +33%
poly_caddq ✅ 4s 3s +33%
poly_chknorm_native ✅ 4s 2s +100%
poly_permute_bitrev_to_custom_optional ✅ 4s 3s +33%
poly_permute_bitrev_to_custom_optional_native ✅ 4s 5s -20%
poly_pointwise_montgomery ✅ 4s 4s +0%
poly_shiftl ✅ 4s 3s +33%
poly_sub ✅ 4s 3s +33%
poly_uniform_gamma1 ✅ 4s 3s +33%
poly_uniform_gamma1_4x ✅ 4s 4s +0%
poly_use_hint_native_aarch64 ✅ 4s 3s +33%
polyt1_unpack ✅ 4s 5s -20%
polyveck_unpack_t0 ✅ 4s 4s +0%
polyz_unpack ✅ 4s 2s +100%
rej_eta_native ✅ 4s 3s +33%
shake256_absorb ✅ 4s 3s +33%
shake256_squeeze ✅ 4s 3s +33%
sign_open ✅ 4s 7s -43%
sign_signature ✅ 4s 3s +33%
sign_verify ✅ 4s 3s +33%
sk_s1hat_get_poly ✅ 4s 4s +0%
sk_s2hat_get_poly ✅ 4s 3s +33%
unpack_sk ✅ 4s 3s +33%
unpack_sk_s1hat ✅ 4s 3s +33%
caddq ✅ 3s 3s +0%
keccak_f1600_x1_native_aarch64_v84a ✅ 3s 2s +50%
keccak_f1600_x4_native_aarch64_v84a ✅ 3s 3s +0%
keccak_f1600_x4_native_avx2 ✅ 3s 2s +50%
mld_ct_cmask_nonzero_u8 ✅ 3s 2s +50%
mld_ct_get_optblocker_u32 ✅ 3s 3s +0%
mld_ct_get_optblocker_u8 ✅ 3s 2s +50%
mld_ct_sel_int32 ✅ 3s 2s +50%
mld_sample_s1_s2 ✅ 3s 4s -25%
ntt_native_aarch64 ✅ 3s 5s -40%
pack_sig_c ✅ 3s 4s -25%
pack_sk_rho_key_tr_s2_t0 ✅ 3s 2s +50%
pack_sk_s1 ✅ 3s 2s +50%
pointwise_native_aarch64 ✅ 3s 4s -25%
poly_caddq_c ✅ 3s 4s -25%
poly_caddq_native_aarch64 ✅ 3s 2s +50%
poly_decompose_native ✅ 3s 4s -25%
poly_ntt ✅ 3s 4s -25%
poly_pointwise_montgomery_native ✅ 3s 4s -25%
poly_reduce ✅ 3s 3s +0%
poly_use_hint ✅ 3s 4s -25%
poly_use_hint_c ✅ 3s 5s -40%
polyt1_pack ✅ 3s 3s +0%
polyvec_matrix_pointwise_montgomery_row ✅ 3s 5s -40%
polyveck_pack_eta ✅ 3s 5s -40%
polyvecl_pointwise_acc_montgomery ✅ 3s 6s -50%
polyvecl_uniform_gamma1 ✅ 3s 4s -25%
polyvecl_unpack_z ✅ 3s 3s +0%
polyz_pack ✅ 3s 3s +0%
polyz_unpack_c ✅ 3s 7s -57%
rej_eta_c ✅ 3s 4s -25%
shake128_init ✅ 3s 1s +200%
shake128_squeeze ✅ 3s 2s +50%
shake256_finalize ✅ 3s 2s +50%
shake256x4_squeezeblocks ✅ 3s 8s -62%
sign_keypair ✅ 3s 3s +0%
sign_signature_extmu ✅ 3s 3s +0%
sign_signature_pre_hash_internal ✅ 3s 4s -25%
sign_signature_pre_hash_shake256 ✅ 3s 3s +0%
sign_verify_extmu ✅ 3s 6s -50%
sign_verify_pre_hash_shake256 ✅ 3s 5s -40%
sk_t0hat_get_poly ✅ 3s 3s +0%
unpack_pk ✅ 3s 4s -25%
unpack_sk_t0hat ✅ 3s 2s +50%
use_hint ✅ 3s 3s +0%
intt_native_x86_64 ✅ 2s 3s -33%
keccak_f1600_x1_native_aarch64 ✅ 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 2s 1s +100%
keccak_init ✅ 2s 3s -33%
keccakf1600_xor_bytes ✅ 2s 3s -33%
keccakf1600x4_extract_bytes ✅ 2s 2s +0%
keccakf1600x4_xor_bytes ✅ 2s 3s -33%
mld_ct_abs_i32 ✅ 2s 1s +100%
mld_ct_cmask_neg_i32 ✅ 2s 2s +0%
mld_ct_cmask_nonzero_u32 ✅ 2s 3s -33%
mld_ct_get_optblocker_i64 ✅ 2s 3s -33%
mld_keccakf1600_extract_bytes ✅ 2s 4s -50%
mld_polymat_expand_entry ✅ 2s 2s +0%
mld_value_barrier_u32 ✅ 2s 1s +100%
montgomery_reduce ✅ 2s 2s +0%
poly_chknorm ✅ 2s 2s +0%
poly_chknorm_native_aarch64 ✅ 2s 4s -50%
poly_decompose ✅ 2s 6s -67%
poly_invntt_tomont ✅ 2s 2s +0%
poly_ntt_c ✅ 2s 3s -33%
poly_ntt_native ✅ 2s 1s +100%
polyeta_pack ✅ 2s 4s -50%
polyw1_pack ✅ 2s 3s -33%
polyz_unpack_17_native_aarch64 ✅ 2s 3s -33%
reduce32 ✅ 2s 4s -50%
rej_eta ✅ 2s 3s -33%
shake128_finalize ✅ 2s 3s -33%
shake128x4_absorb_once ✅ 2s 4s -50%
shake256 ✅ 2s 3s -33%
shake256x4_absorb_once ✅ 2s 2s +0%
yvec_get_poly ✅ 2s 3s -33%
yvec_init ✅ 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 1s 3s -67%
keccak_finalize ✅ 1s 2s -50%
keccak_squeeze ✅ 1s 2s -50%
keccakf1600_extract_bytes (big endian) ✅ 1s 2s -50%
mld_value_barrier_i64 ✅ 1s 2s -50%
mld_value_barrier_u8 ✅ 1s 1s +0%
polyvecl_unpack_eta ✅ 1s 2s -50%
polyz_unpack_native ✅ 1s 1s +0%
shake128_absorb ✅ 1s 2s -50%
shake128_release ✅ 1s 2s -50%
shake128x4_squeezeblocks ✅ 1s 4s -75%
shake256_init ✅ 1s 1s +0%
shake256_release ✅ 1s 2s -50%
unpack_sig ✅ 1s 4s -75%

@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch from 4ca59ed to edf6619 Compare April 8, 2026 06:58
@mkannwischer mkannwischer marked this pull request as ready for review April 8, 2026 08:37
@mkannwischer mkannwischer requested a review from a team as a code owner April 8, 2026 08:37
hanno-becker
hanno-becker reviewed Apr 9, 2026
View reviewed changes
Comment thread mldsa/src/packing.c Outdated
hanno-becker
hanno-becker requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good, but I'd prefer a clean error signal when there are too many hints, see comment.

@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch 2 times, most recently from 7b6a8a4 to e8dabd1 Compare April 9, 2026 09:25
jakemas
jakemas approved these changes Apr 14, 2026
View reviewed changes
Comment thread mldsa/src/sign.c
assigns(k, n,
memory_slice(z, sizeof(mld_poly)),
memory_slice(sig, MLDSA_CRYPTO_BYTES))
assigns(k, n, ret, memory_slice(sig, MLDSA_CRYPTO_BYTES))
Copy link
Copy Markdown
Contributor

@jakemas jakemas Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice side effect: z is no longer reused as scratch in the hint loop, so its lifetime can end before hint packing begins. Perhaps relevant for the low-memory implementation since that's one fewer mld_poly (~1 KiB ?) on the stack during this phase.

@mkannwischer
sign: Consolidate make_hint and pack_sig_h_poly
83f8140 
Replace mld_poly_make_hint + mld_pack_sig_h_poly with a single
mld_make_pack_sig_h_poly that takes (a0, a1) directly, computes hint
bits via mld_make_hint, writes hint indices into sig in one pass, and
returns the updated running tally. The function returns MLD_ERR_FAIL
if the number of hints would exceed MLDSA_OMEGA.

This removes the duplicated hint counting (previously make_hint
returned the count and pack iterated the hint poly again without
re-validating) and drops the temporary scratch hint polynomial from
the sign.c hint loop.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch from e8dabd1 to 83f8140 Compare May 3, 2026 01:34
@mkannwischer
Copy link
Copy Markdown
Contributor Author

mkannwischer commented May 3, 2026

Rebased on top of main. Please take another look @hanno-becker.

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented May 3, 2026

CBMC Results (ML-DSA-65, REDUCE-RAM)

Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 1725s 1737s -0.7%
poly_pointwise_montgomery_c ✅ 173s 201s -14%
sign_verify_internal ✅ 142s 125s +14%
rej_uniform_native ✅ 111s 116s -4%
mld_invntt_layer ✅ 106s 116s -9%
polyvec_matrix_pointwise_montgomery_yvec ✅ 104s 80s +30%
mld_ct_memcmp ✅ 77s 81s -5%
mld_ntt_layer ✅ 43s 45s -4%
fqmul ✅ 29s 30s -3%
sign_keypair_internal ✅ 29s 22s +32%
mld_attempt_signature_generation ✅ 27s 30s -10%
keccakf1600x4_permute_native ✅ 22s 23s -4%
polyveck_decompose ✅ 22s 18s +22%
rej_uniform ✅ 19s 20s -5%
polyvecl_chknorm ✅ 18s 9s +100%
rej_uniform_c ✅ 17s 19s -11%
mld_ntt_butterfly_block ✅ 16s 17s -6%
poly_chknorm_c ✅ 16s 14s +14%
sign_pk_from_sk ✅ 16s 14s +14%
polyveck_pointwise_poly_montgomery ✅ 13s 8s +62%
poly_uniform_eta_4x ✅ 12s 11s +9%
mld_check_pct ✅ 11s 12s -8%
poly_add ✅ 11s 11s +0%
polyt0_unpack ✅ 11s 10s +10%
polyveck_ntt ✅ 11s 6s +83%
polyveck_power2round ✅ 11s 17s -35%
polyveck_use_hint ✅ 11s 12s -8%
mld_sample_s1_s2 ✅ 9s 5s +80%
poly_caddq_c ✅ 9s 9s +0%
polyveck_add ✅ 9s 12s -25%
pointwise_acc_native_x86_64 ✅ 8s 8s +0%
poly_shiftl ✅ 8s 5s +60%
polyveck_reduce ✅ 8s 5s +60%
polyvecl_ntt ✅ 8s 9s -11%
polyz_pack ✅ 8s 3s +167%
polyz_unpack_c ✅ 8s 4s +100%
sign ✅ 8s 9s -11%
sign_open ✅ 8s 3s +167%
sign_signature_internal ✅ 8s 6s +33%
keccak_absorb_once_x4 ✅ 7s 8s -12%
keccakf1600_permute ✅ 7s 7s +0%
keccakf1600_permute_native ✅ 7s 9s -22%
poly_chknorm ✅ 7s 6s +17%
poly_invntt_tomont_c ✅ 7s 8s -12%
polyveck_invntt_tomont ✅ 7s 8s -12%
polyveck_shiftl ✅ 7s 5s +40%
polyveck_sub ✅ 7s 6s +17%
keccak_absorb ✅ 6s 9s -33%
pointwise_acc_native_aarch64 ✅ 6s 7s -14%
poly_power2round ✅ 6s 7s -14%
unpack_pk ✅ 6s 3s +100%
unpack_sk ✅ 6s 3s +100%
caddq ✅ 5s 2s +150%
keccakf1600_extract_bytes (big endian) ✅ 5s 2s +150%
make_pack_sig_h_poly ✅ 5s - new
mld_compute_pack_z ✅ 5s 6s -17%
mld_ct_cmask_nonzero_u8 ✅ 5s 2s +150%
nttunpack_native_x86_64 ✅ 5s 5s +0%
poly_decompose ✅ 5s 2s +150%
poly_uniform_4x ✅ 5s 4s +25%
poly_uniform_eta ✅ 5s 4s +25%
polyvec_matrix_pointwise_montgomery ✅ 5s 6s -17%
polyvec_matrix_pointwise_montgomery_row ✅ 5s 15s -67%
polyveck_caddq ✅ 5s 8s -38%
rej_eta_native ✅ 5s 4s +25%
sign_signature_pre_hash_internal ✅ 5s 5s +0%
sign_verify_extmu ✅ 5s 4s +25%
sk_s1hat_get_poly ✅ 5s 2s +150%
sk_s2hat_get_poly ✅ 5s 6s -17%
unpack_hints ✅ 5s 4s +25%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 4s 3s +33%
keccak_squeeze ✅ 4s 4s +0%
keccak_squeezeblocks_x4 ✅ 4s 4s +0%
mld_ct_get_optblocker_i64 ✅ 4s 3s +33%
mld_h ✅ 4s 5s -20%
mld_prepare_domain_separation_prefix ✅ 4s 6s -33%
ntt_native_aarch64 ✅ 4s 4s +0%
pack_pk ✅ 4s 5s -20%
poly_caddq_native ✅ 4s 3s +33%
poly_decompose_native ✅ 4s 3s +33%
poly_invntt_tomont_native ✅ 4s 5s -20%
poly_ntt_native ✅ 4s 3s +33%
poly_sub ✅ 4s 3s +33%
poly_uniform ✅ 4s 6s -33%
poly_uniform_gamma1 ✅ 4s 4s +0%
poly_use_hint_c ✅ 4s 4s +0%
polyeta_pack ✅ 4s 3s +33%
polyeta_unpack ✅ 4s 3s +33%
polyt1_unpack ✅ 4s 2s +100%
polyvec_matrix_expand ✅ 4s 1s +300%
polyvec_matrix_expand_serial ✅ 4s 3s +33%
polyveck_chknorm ✅ 4s 7s -43%
polyveck_unpack_eta ✅ 4s 3s +33%
polyveck_unpack_t0 ✅ 4s 3s +33%
polyvecl_pack_eta ✅ 4s 3s +33%
polyvecl_unpack_eta ✅ 4s 6s -33%
polyw1_pack ✅ 4s 3s +33%
polyz_unpack_17_native_aarch64 ✅ 4s 3s +33%
polyz_unpack_19_native_aarch64 ✅ 4s 3s +33%
shake128_absorb ✅ 4s 4s +0%
shake256_finalize ✅ 4s 2s +100%
shake256_init ✅ 4s 3s +33%
sign_verify ✅ 4s 4s +0%
sign_verify_pre_hash_internal ✅ 4s 3s +33%
sign_verify_pre_hash_shake256 ✅ 4s 4s +0%
sk_t0hat_get_poly ✅ 4s 5s -20%
use_hint ✅ 4s 4s +0%
fqscale ✅ 3s 4s -25%
keccak_f1600_x1_native_aarch64 ✅ 3s 4s -25%
keccak_f1600_x1_native_aarch64_v84a ✅ 3s 2s +50%
keccak_f1600_x4_native_avx2 ✅ 3s 3s +0%
keccak_init ✅ 3s 4s -25%
mld_ct_get_optblocker_u32 ✅ 3s 3s +0%
mld_ct_sel_int32 ✅ 3s 2s +50%
mld_sample_s1_s2_serial ✅ 3s 3s +0%
mld_value_barrier_i64 ✅ 3s 2s +50%
mld_value_barrier_u8 ✅ 3s 2s +50%
montgomery_reduce ✅ 3s 3s +0%
ntt_native_x86_64 ✅ 3s 3s +0%
pack_sk_rho_key_tr_s2_t0 ✅ 3s 2s +50%
pack_sk_s1 ✅ 3s 3s +0%
pointwise_native_aarch64 ✅ 3s 4s -25%
poly_caddq ✅ 3s 3s +0%
poly_challenge ✅ 3s 6s -50%
poly_decompose_c ✅ 3s 5s -40%
poly_invntt_tomont ✅ 3s 4s -25%
poly_ntt ✅ 3s 2s +50%
poly_permute_bitrev_to_custom_optional ✅ 3s 2s +50%
poly_reduce ✅ 3s 3s +0%
poly_uniform_gamma1_4x ✅ 3s 7s -57%
poly_use_hint ✅ 3s 3s +0%
poly_use_hint_native_aarch64 ✅ 3s 2s +50%
polyt0_pack ✅ 3s 5s -40%
polyveck_pack_t0 ✅ 3s 3s +0%
polyveck_pack_w1 ✅ 3s 4s -25%
polyvecl_pointwise_acc_montgomery ✅ 3s 2s +50%
polyvecl_pointwise_acc_montgomery_native ✅ 3s 3s +0%
polyvecl_uniform_gamma1 ✅ 3s 3s +0%
polyvecl_unpack_z ✅ 3s 4s -25%
polyz_unpack ✅ 3s 2s +50%
power2round ✅ 3s 3s +0%
reduce32 ✅ 3s 2s +50%
rej_eta ✅ 3s 3s +0%
shake128_finalize ✅ 3s 3s +0%
shake128_release ✅ 3s 4s -25%
shake128x4_squeezeblocks ✅ 3s 2s +50%
shake256 ✅ 3s 4s -25%
shake256_absorb ✅ 3s 3s +0%
shake256_squeeze ✅ 3s 1s +200%
sign_keypair ✅ 3s 3s +0%
sign_signature_extmu ✅ 3s 4s -25%
sign_signature_pre_hash_shake256 ✅ 3s 4s -25%
sys_check_capability ✅ 3s 3s +0%
unpack_sig ✅ 3s 2s +50%
unpack_sk_s2hat ✅ 3s 3s +0%
unpack_sk_t0hat ✅ 3s 2s +50%
yvec_get_poly ✅ 3s 4s -25%
decompose ✅ 2s 2s +0%
intt_native_x86_64 ✅ 2s 5s -60%
keccak_finalize ✅ 2s 3s -33%
keccakf1600_xor_bytes ✅ 2s 2s +0%
keccakf1600_xor_bytes (big endian) ✅ 2s 2s +0%
keccakf1600x4_extract_bytes ✅ 2s 2s +0%
keccakf1600x4_permute ✅ 2s 3s -33%
keccakf1600x4_xor_bytes ✅ 2s 2s +0%
make_hint ✅ 2s 3s -33%
mld_keccakf1600_extract_bytes ✅ 2s 2s +0%
mld_polymat_expand_entry ✅ 2s 3s -33%
pack_sig_c ✅ 2s 3s -33%
pack_sig_z ✅ 2s 1s +100%
pointwise_native_x86_64 ✅ 2s 2s +0%
poly_caddq_native_aarch64 ✅ 2s 3s -33%
poly_chknorm_native ✅ 2s 4s -50%
poly_chknorm_native_aarch64 ✅ 2s 4s -50%
poly_pointwise_montgomery ✅ 2s 5s -60%
poly_use_hint_native ✅ 2s 5s -60%
polyt1_pack ✅ 2s 2s +0%
polyvecl_pointwise_acc_montgomery_c ✅ 2s 3s -33%
polyvecl_uniform_gamma1_serial ✅ 2s 2s +0%
polyz_unpack_native ✅ 2s 4s -50%
rej_eta_c ✅ 2s 4s -50%
shake128_squeeze ✅ 2s 3s -33%
shake256_release ✅ 2s 2s +0%
shake256x4_squeezeblocks ✅ 2s 2s +0%
sign_signature ✅ 2s 8s -75%
unpack_sk_s1hat ✅ 2s 1s +100%
yvec_init ✅ 2s 2s +0%
keccak_f1600_x4_native_aarch64_v84a ✅ 1s 2s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 1s 3s -67%
mld_ct_abs_i32 ✅ 1s 2s -50%
mld_ct_cmask_neg_i32 ✅ 1s 2s -50%
mld_ct_cmask_nonzero_u32 ✅ 1s 3s -67%
mld_ct_get_optblocker_u8 ✅ 1s 3s -67%
mld_value_barrier_u32 ✅ 1s 2s -50%
poly_ntt_c ✅ 1s 4s -75%
poly_permute_bitrev_to_custom_optional_native ✅ 1s 3s -67%
poly_pointwise_montgomery_native ✅ 1s 3s -67%
polyveck_pack_eta ✅ 1s 4s -75%
shake128_init ✅ 1s 3s -67%
shake128x4_absorb_once ✅ 1s 2s -50%
shake256x4_absorb_once ✅ 1s 1s +0%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented May 3, 2026

CBMC Results (ML-DSA-87, REDUCE-RAM)

⚠️ Attention Required

Proof Status Current Previous Change
polyvecl_chknorm ⚠️ 36s 6s +500%
Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 1816s 1808s +0.4%
poly_pointwise_montgomery_c ✅ 188s 169s +11%
sign_verify_internal ✅ 156s 238s -34%
polyvec_matrix_pointwise_montgomery_yvec ✅ 144s 140s +3%
mld_invntt_layer ✅ 108s 105s +3%
rej_uniform_native ✅ 108s 105s +3%
mld_ct_memcmp ✅ 79s 73s +8%
mld_ntt_layer ✅ 46s 43s +7%
polyvecl_chknorm ⚠️ 36s 6s +500%
sign_keypair_internal ✅ 34s 33s +3%
fqmul ✅ 30s 27s +11%
keccakf1600x4_permute_native ✅ 22s 22s +0%
rej_uniform ✅ 22s 24s -8%
sign_pk_from_sk ✅ 21s 18s +17%
mld_attempt_signature_generation ✅ 20s 23s -13%
polyeta_unpack ✅ 20s 20s +0%
rej_uniform_c ✅ 18s 17s +6%
mld_ntt_butterfly_block ✅ 16s 15s +7%
poly_chknorm_c ✅ 15s 14s +7%
mld_check_pct ✅ 14s 12s +17%
poly_uniform_eta_4x ✅ 13s 13s +0%
poly_invntt_tomont_c ✅ 12s 9s +33%
polyveck_use_hint ✅ 12s 8s +50%
poly_add ✅ 11s 13s -15%
polyt0_unpack ✅ 11s 14s -21%
polyveck_decompose ✅ 11s 15s -27%
polyveck_power2round ✅ 11s 8s +38%
mld_sample_s1_s2 ✅ 9s 6s +50%
poly_shiftl ✅ 9s 7s +29%
polyveck_caddq ✅ 9s 5s +80%
polyveck_pointwise_poly_montgomery ✅ 9s 9s +0%
polyveck_reduce ✅ 9s 5s +80%
keccak_absorb_once_x4 ✅ 8s 10s -20%
pointwise_acc_native_x86_64 ✅ 8s 6s +33%
poly_caddq_c ✅ 8s 8s +0%
poly_power2round ✅ 8s 8s +0%
polyveck_add ✅ 8s 9s -11%
polyveck_ntt ✅ 8s 8s +0%
polyveck_sub ✅ 8s 7s +14%
polyvecl_ntt ✅ 8s 3s +167%
keccakf1600_permute ✅ 7s 7s +0%
keccakf1600_permute_native ✅ 7s 7s +0%
pointwise_acc_native_aarch64 ✅ 7s 8s -12%
polyvec_matrix_pointwise_montgomery_row ✅ 7s 13s -46%
polyveck_invntt_tomont ✅ 7s 9s -22%
polyz_unpack_c ✅ 7s 3s +133%
sign ✅ 7s 7s +0%
keccak_absorb ✅ 6s 7s -14%
polyveck_unpack_t0 ✅ 6s 3s +100%
sign_signature ✅ 6s 2s +200%
sk_s1hat_get_poly ✅ 6s 2s +200%
unpack_sig ✅ 6s 2s +200%
mld_prepare_domain_separation_prefix ✅ 5s 3s +67%
mld_sample_s1_s2_serial ✅ 5s 6s -17%
poly_challenge ✅ 5s 4s +25%
poly_decompose_c ✅ 5s 5s +0%
poly_invntt_tomont ✅ 5s 1s +400%
poly_pointwise_montgomery_native ✅ 5s 2s +150%
polyt1_pack ✅ 5s 1s +400%
polyvec_matrix_pointwise_montgomery ✅ 5s 7s -29%
polyveck_shiftl ✅ 5s 7s -29%
polyveck_unpack_eta ✅ 5s 4s +25%
polyz_unpack ✅ 5s 1s +400%
polyz_unpack_native ✅ 5s 5s +0%
power2round ✅ 5s 2s +150%
shake128_init ✅ 5s 4s +25%
sign_signature_pre_hash_shake256 ✅ 5s 4s +25%
sign_verify ✅ 5s 5s +0%
sign_verify_pre_hash_shake256 ✅ 5s 6s -17%
make_hint ✅ 4s 4s +0%
mld_compute_pack_z ✅ 4s 6s -33%
mld_h ✅ 4s 4s +0%
mld_keccakf1600_extract_bytes ✅ 4s 3s +33%
mld_value_barrier_i64 ✅ 4s 2s +100%
montgomery_reduce ✅ 4s 3s +33%
pack_pk ✅ 4s 2s +100%
pointwise_native_aarch64 ✅ 4s 2s +100%
poly_caddq_native ✅ 4s 5s -20%
poly_chknorm ✅ 4s 1s +300%
poly_invntt_tomont_native ✅ 4s 1s +300%
poly_pointwise_montgomery ✅ 4s 3s +33%
poly_reduce ✅ 4s 4s +0%
poly_uniform ✅ 4s 4s +0%
poly_uniform_4x ✅ 4s 4s +0%
poly_uniform_eta ✅ 4s 4s +0%
polyeta_pack ✅ 4s 5s -20%
polyt1_unpack ✅ 4s 3s +33%
polyveck_chknorm ✅ 4s 7s -43%
polyveck_pack_eta ✅ 4s 2s +100%
polyvecl_uniform_gamma1 ✅ 4s 2s +100%
polyvecl_uniform_gamma1_serial ✅ 4s 2s +100%
rej_eta_native ✅ 4s 4s +0%
shake256_init ✅ 4s 4s +0%
sign_signature_internal ✅ 4s 4s +0%
sign_verify_extmu ✅ 4s 7s -43%
sign_verify_pre_hash_internal ✅ 4s 3s +33%
unpack_hints ✅ 4s 5s -20%
unpack_pk ✅ 4s 5s -20%
unpack_sk_t0hat ✅ 4s 4s +0%
yvec_get_poly ✅ 4s 2s +100%
caddq ✅ 3s 2s +50%
decompose ✅ 3s 2s +50%
intt_native_x86_64 ✅ 3s 2s +50%
keccak_f1600_x4_native_avx2 ✅ 3s 4s -25%
keccak_init ✅ 3s 3s +0%
keccak_squeezeblocks_x4 ✅ 3s 5s -40%
keccakf1600_xor_bytes ✅ 3s 4s -25%
keccakf1600x4_extract_bytes ✅ 3s 4s -25%
keccakf1600x4_xor_bytes ✅ 3s 4s -25%
make_pack_sig_h_poly ✅ 3s - new
mld_ct_cmask_nonzero_u32 ✅ 3s 2s +50%
mld_ct_get_optblocker_i64 ✅ 3s 1s +200%
mld_ct_sel_int32 ✅ 3s 2s +50%
mld_polymat_expand_entry ✅ 3s 4s -25%
ntt_native_aarch64 ✅ 3s 2s +50%
nttunpack_native_x86_64 ✅ 3s 3s +0%
pack_sk_rho_key_tr_s2_t0 ✅ 3s 5s -40%
pack_sk_s1 ✅ 3s 2s +50%
pointwise_native_x86_64 ✅ 3s 3s +0%
poly_decompose ✅ 3s 2s +50%
poly_decompose_native ✅ 3s 3s +0%
poly_ntt_native ✅ 3s 3s +0%
poly_permute_bitrev_to_custom_optional ✅ 3s 2s +50%
poly_permute_bitrev_to_custom_optional_native ✅ 3s 3s +0%
poly_uniform_gamma1 ✅ 3s 4s -25%
poly_uniform_gamma1_4x ✅ 3s 2s +50%
poly_use_hint ✅ 3s 2s +50%
poly_use_hint_c ✅ 3s 5s -40%
poly_use_hint_native ✅ 3s 4s -25%
poly_use_hint_native_aarch64 ✅ 3s 3s +0%
polyt0_pack ✅ 3s 5s -40%
polyveck_pack_t0 ✅ 3s 3s +0%
polyvecl_pointwise_acc_montgomery_c ✅ 3s 3s +0%
polyvecl_pointwise_acc_montgomery_native ✅ 3s 3s +0%
polyvecl_unpack_eta ✅ 3s 3s +0%
polyz_unpack_17_native_aarch64 ✅ 3s 4s -25%
polyz_unpack_19_native_aarch64 ✅ 3s 3s +0%
rej_eta_c ✅ 3s 4s -25%
shake128x4_absorb_once ✅ 3s 2s +50%
shake256 ✅ 3s 1s +200%
shake256_absorb ✅ 3s 3s +0%
shake256x4_squeezeblocks ✅ 3s 2s +50%
sign_keypair ✅ 3s 4s -25%
sign_open ✅ 3s 2s +50%
sign_signature_extmu ✅ 3s 2s +50%
sign_signature_pre_hash_internal ✅ 3s 4s -25%
sk_s2hat_get_poly ✅ 3s 3s +0%
unpack_sk ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64 ✅ 2s 3s -33%
keccak_f1600_x1_native_aarch64_v84a ✅ 2s 1s +100%
keccak_f1600_x4_native_aarch64_v84a ✅ 2s 4s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 2s 1s +100%
keccak_finalize ✅ 2s 2s +0%
keccak_squeeze ✅ 2s 2s +0%
keccakf1600_extract_bytes (big endian) ✅ 2s 3s -33%
keccakf1600_xor_bytes (big endian) ✅ 2s 2s +0%
mld_ct_abs_i32 ✅ 2s 1s +100%
mld_ct_cmask_neg_i32 ✅ 2s 2s +0%
mld_ct_get_optblocker_u32 ✅ 2s 3s -33%
mld_ct_get_optblocker_u8 ✅ 2s 2s +0%
mld_value_barrier_u8 ✅ 2s 2s +0%
ntt_native_x86_64 ✅ 2s 2s +0%
pack_sig_c ✅ 2s 3s -33%
pack_sig_z ✅ 2s 4s -50%
poly_caddq_native_aarch64 ✅ 2s 2s +0%
poly_chknorm_native_aarch64 ✅ 2s 2s +0%
poly_ntt ✅ 2s 2s +0%
poly_ntt_c ✅ 2s 5s -60%
poly_sub ✅ 2s 2s +0%
polyvec_matrix_expand ✅ 2s 3s -33%
polyveck_pack_w1 ✅ 2s 3s -33%
polyvecl_pack_eta ✅ 2s 3s -33%
polyvecl_pointwise_acc_montgomery ✅ 2s 3s -33%
polyw1_pack ✅ 2s 1s +100%
polyz_pack ✅ 2s 5s -60%
reduce32 ✅ 2s 4s -50%
rej_eta ✅ 2s 3s -33%
shake128_absorb ✅ 2s 3s -33%
shake128_finalize ✅ 2s 3s -33%
shake128_release ✅ 2s 1s +100%
shake128_squeeze ✅ 2s 2s +0%
shake128x4_squeezeblocks ✅ 2s 4s -50%
shake256_finalize ✅ 2s 5s -60%
shake256_release ✅ 2s 1s +100%
shake256_squeeze ✅ 2s 3s -33%
shake256x4_absorb_once ✅ 2s 3s -33%
sk_t0hat_get_poly ✅ 2s 3s -33%
sys_check_capability ✅ 2s 2s +0%
unpack_sk_s1hat ✅ 2s 4s -50%
unpack_sk_s2hat ✅ 2s 3s -33%
use_hint ✅ 2s 4s -50%
yvec_init ✅ 2s 4s -50%
fqscale ✅ 1s 1s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 1s 2s -50%
keccakf1600x4_permute ✅ 1s 3s -67%
mld_ct_cmask_nonzero_u8 ✅ 1s 2s -50%
mld_value_barrier_u32 ✅ 1s 1s +0%
poly_caddq ✅ 1s 3s -67%
poly_chknorm_native ✅ 1s 3s -67%
polyvec_matrix_expand_serial ✅ 1s 2s -50%
polyvecl_unpack_z ✅ 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented May 3, 2026

CBMC Results (ML-DSA-44, REDUCE-RAM)

⚠️ Attention Required

Proof Status Current Previous Change
sign_verify_internal ⚠️ 105s 65s +62%
Full Results (200 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 1634s 1562s +4.6%
poly_pointwise_montgomery_c ✅ 200s 185s +8%
rej_uniform_native ✅ 116s 112s +4%
mld_invntt_layer ✅ 112s 107s +5%
sign_verify_internal ⚠️ 105s 65s +62%
mld_ct_memcmp ✅ 77s 78s -1%
polyvec_matrix_pointwise_montgomery_yvec ✅ 54s 65s -17%
mld_ntt_layer ✅ 48s 45s +7%
fqmul ✅ 31s 32s -3%
mld_attempt_signature_generation ✅ 23s 24s -4%
keccakf1600x4_permute_native ✅ 22s 23s -4%
rej_uniform ✅ 21s 21s +0%
rej_uniform_c ✅ 19s 21s -10%
sign_pk_from_sk ✅ 18s 16s +12%
mld_ntt_butterfly_block ✅ 17s 15s +13%
sign_keypair_internal ✅ 17s 15s +13%
polyeta_unpack ✅ 16s 21s -24%
polyveck_pointwise_poly_montgomery ✅ 16s 9s +78%
poly_chknorm_c ✅ 15s 13s +15%
polyz_unpack_c ✅ 14s 2s +600%
poly_uniform_eta_4x ✅ 13s 15s -13%
mld_check_pct ✅ 12s 14s -14%
polyt0_unpack ✅ 12s 12s +0%
keccak_absorb_once_x4 ✅ 10s 9s +11%
mld_compute_pack_z ✅ 9s 6s +50%
poly_add ✅ 9s 12s -25%
poly_caddq_c ✅ 9s 8s +12%
poly_invntt_tomont_c ✅ 9s 10s -10%
polyveck_decompose ✅ 9s 7s +29%
poly_decompose_c ✅ 7s 7s +0%
poly_uniform ✅ 7s 4s +75%
sign_signature_extmu ✅ 7s 3s +133%
keccakf1600_permute ✅ 6s 7s -14%
keccakf1600_permute_native ✅ 6s 6s +0%
mld_h ✅ 6s 4s +50%
poly_caddq ✅ 6s 2s +200%
poly_caddq_native ✅ 6s 1s +500%
polyvec_matrix_pointwise_montgomery_row ✅ 6s 8s -25%
polyveck_ntt ✅ 6s 5s +20%
polyveck_pack_t0 ✅ 6s 4s +50%
polyveck_pack_w1 ✅ 6s 3s +100%
polyveck_shiftl ✅ 6s 4s +50%
polyvecl_unpack_z ✅ 6s 2s +200%
polyz_unpack_17_native_aarch64 ✅ 6s 4s +50%
unpack_hints ✅ 6s 6s +0%
keccak_absorb ✅ 5s 6s -17%
mld_prepare_domain_separation_prefix ✅ 5s 5s +0%
ntt_native_x86_64 ✅ 5s 3s +67%
pack_pk ✅ 5s 2s +150%
pack_sig_z ✅ 5s 3s +67%
pointwise_acc_native_aarch64 ✅ 5s 5s +0%
poly_chknorm_native_aarch64 ✅ 5s 3s +67%
poly_power2round ✅ 5s 7s -29%
poly_shiftl ✅ 5s 5s +0%
poly_uniform_gamma1_4x ✅ 5s 2s +150%
polyvec_matrix_expand_serial ✅ 5s 2s +150%
polyvec_matrix_pointwise_montgomery ✅ 5s 2s +150%
polyveck_add ✅ 5s 8s -38%
polyveck_chknorm ✅ 5s 6s -17%
polyveck_unpack_t0 ✅ 5s 2s +150%
polyveck_use_hint ✅ 5s 15s -67%
polyvecl_unpack_eta ✅ 5s 4s +25%
power2round ✅ 5s 3s +67%
rej_eta_c ✅ 5s 6s -17%
shake128x4_absorb_once ✅ 5s 2s +150%
sign ✅ 5s 5s +0%
sign_open ✅ 5s 5s +0%
sign_signature_pre_hash_internal ✅ 5s 5s +0%
sign_signature_pre_hash_shake256 ✅ 5s 3s +67%
sign_verify_pre_hash_shake256 ✅ 5s 2s +150%
keccak_squeeze ✅ 4s 2s +100%
keccak_squeezeblocks_x4 ✅ 4s 4s +0%
make_hint ✅ 4s 5s -20%
mld_ct_cmask_nonzero_u8 ✅ 4s 2s +100%
mld_keccakf1600_extract_bytes ✅ 4s 3s +33%
mld_polymat_expand_entry ✅ 4s 3s +33%
ntt_native_aarch64 ✅ 4s 3s +33%
nttunpack_native_x86_64 ✅ 4s 5s -20%
pointwise_acc_native_x86_64 ✅ 4s 8s -50%
poly_caddq_native_aarch64 ✅ 4s 3s +33%
poly_challenge ✅ 4s 3s +33%
poly_decompose ✅ 4s 3s +33%
poly_invntt_tomont ✅ 4s 1s +300%
poly_ntt ✅ 4s 2s +100%
poly_pointwise_montgomery ✅ 4s 3s +33%
poly_pointwise_montgomery_native ✅ 4s 2s +100%
poly_reduce ✅ 4s 5s -20%
poly_sub ✅ 4s 6s -33%
poly_uniform_eta ✅ 4s 3s +33%
poly_use_hint_c ✅ 4s 2s +100%
polyt1_pack ✅ 4s 2s +100%
polyveck_caddq ✅ 4s 6s -33%
polyveck_invntt_tomont ✅ 4s 6s -33%
polyveck_power2round ✅ 4s 4s +0%
polyveck_reduce ✅ 4s 5s -20%
polyveck_sub ✅ 4s 4s +0%
polyveck_unpack_eta ✅ 4s 2s +100%
polyvecl_pack_eta ✅ 4s 2s +100%
polyvecl_pointwise_acc_montgomery ✅ 4s 2s +100%
polyvecl_uniform_gamma1 ✅ 4s 4s +0%
rej_eta ✅ 4s 3s +33%
rej_eta_native ✅ 4s 3s +33%
shake128_release ✅ 4s 2s +100%
shake128_squeeze ✅ 4s 3s +33%
shake256_release ✅ 4s 4s +0%
sign_keypair ✅ 4s 6s -33%
sign_signature_internal ✅ 4s 3s +33%
sign_verify ✅ 4s 4s +0%
sign_verify_extmu ✅ 4s 3s +33%
sk_s1hat_get_poly ✅ 4s 3s +33%
unpack_sk_s2hat ✅ 4s 5s -20%
yvec_get_poly ✅ 4s 2s +100%
decompose ✅ 3s 4s -25%
fqscale ✅ 3s 1s +200%
intt_native_x86_64 ✅ 3s 3s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 3s 2s +50%
keccakf1600_xor_bytes (big endian) ✅ 3s 3s +0%
make_pack_sig_h_poly ✅ 3s - new
mld_ct_get_optblocker_i64 ✅ 3s 2s +50%
mld_ct_get_optblocker_u32 ✅ 3s 2s +50%
mld_sample_s1_s2 ✅ 3s 4s -25%
mld_value_barrier_i64 ✅ 3s 3s +0%
mld_value_barrier_u8 ✅ 3s 1s +200%
montgomery_reduce ✅ 3s 4s -25%
pack_sk_rho_key_tr_s2_t0 ✅ 3s 4s -25%
pointwise_native_x86_64 ✅ 3s 4s -25%
poly_chknorm_native ✅ 3s 3s +0%
poly_decompose_native ✅ 3s 3s +0%
poly_invntt_tomont_native ✅ 3s 4s -25%
poly_ntt_native ✅ 3s 2s +50%
poly_permute_bitrev_to_custom_optional_native ✅ 3s 4s -25%
polyt0_pack ✅ 3s 3s +0%
polyvec_matrix_expand ✅ 3s 2s +50%
polyveck_pack_eta ✅ 3s 5s -40%
polyvecl_chknorm ✅ 3s 5s -40%
polyvecl_ntt ✅ 3s 7s -57%
polyvecl_pointwise_acc_montgomery_native ✅ 3s 3s +0%
polyvecl_uniform_gamma1_serial ✅ 3s 3s +0%
polyz_pack ✅ 3s 2s +50%
polyz_unpack ✅ 3s 2s +50%
shake128_absorb ✅ 3s 3s +0%
shake256_absorb ✅ 3s 5s -40%
shake256_finalize ✅ 3s 2s +50%
shake256_init ✅ 3s 4s -25%
shake256x4_absorb_once ✅ 3s 3s +0%
shake256x4_squeezeblocks ✅ 3s 2s +50%
sign_signature ✅ 3s 5s -40%
sign_verify_pre_hash_internal ✅ 3s 4s -25%
sk_t0hat_get_poly ✅ 3s 2s +50%
unpack_sk ✅ 3s 3s +0%
yvec_init ✅ 3s 3s +0%
caddq ✅ 2s 5s -60%
keccak_f1600_x1_native_aarch64 ✅ 2s 1s +100%
keccak_finalize ✅ 2s 2s +0%
keccak_init ✅ 2s 2s +0%
keccakf1600_extract_bytes (big endian) ✅ 2s 3s -33%
keccakf1600_xor_bytes ✅ 2s 3s -33%
keccakf1600x4_extract_bytes ✅ 2s 2s +0%
keccakf1600x4_xor_bytes ✅ 2s 2s +0%
mld_ct_abs_i32 ✅ 2s 4s -50%
mld_ct_cmask_neg_i32 ✅ 2s 4s -50%
mld_ct_cmask_nonzero_u32 ✅ 2s 3s -33%
mld_ct_get_optblocker_u8 ✅ 2s 3s -33%
mld_ct_sel_int32 ✅ 2s 2s +0%
mld_sample_s1_s2_serial ✅ 2s 6s -67%
mld_value_barrier_u32 ✅ 2s 4s -50%
pack_sig_c ✅ 2s 3s -33%
pack_sk_s1 ✅ 2s 3s -33%
pointwise_native_aarch64 ✅ 2s 2s +0%
poly_chknorm ✅ 2s 2s +0%
poly_ntt_c ✅ 2s 4s -50%
poly_permute_bitrev_to_custom_optional ✅ 2s 3s -33%
poly_uniform_4x ✅ 2s 4s -50%
poly_use_hint ✅ 2s 3s -33%
poly_use_hint_native ✅ 2s 4s -50%
poly_use_hint_native_aarch64 ✅ 2s 3s -33%
polyeta_pack ✅ 2s 3s -33%
polyt1_unpack ✅ 2s 3s -33%
polyw1_pack ✅ 2s 3s -33%
polyz_unpack_19_native_aarch64 ✅ 2s 3s -33%
polyz_unpack_native ✅ 2s 2s +0%
shake128_finalize ✅ 2s 4s -50%
shake128_init ✅ 2s 3s -33%
shake128x4_squeezeblocks ✅ 2s 2s +0%
shake256 ✅ 2s 4s -50%
shake256_squeeze ✅ 2s 1s +100%
sk_s2hat_get_poly ✅ 2s 4s -50%
sys_check_capability ✅ 2s 2s +0%
unpack_pk ✅ 2s 2s +0%
unpack_sig ✅ 2s 3s -33%
unpack_sk_s1hat ✅ 2s 3s -33%
unpack_sk_t0hat ✅ 2s 3s -33%
use_hint ✅ 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a ✅ 1s 3s -67%
keccak_f1600_x4_native_aarch64_v84a ✅ 1s 3s -67%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 1s 2s -50%
keccak_f1600_x4_native_avx2 ✅ 1s 2s -50%
keccakf1600x4_permute ✅ 1s 4s -75%
poly_uniform_gamma1 ✅ 1s 3s -67%
polyvecl_pointwise_acc_montgomery_c ✅ 1s 2s -50%
reduce32 ✅ 1s 3s -67%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemas jakemas jakemas approved these changes

@hanno-becker hanno-becker Awaiting requested review from hanno-becker

Requested changes must be addressed to merge this pull request.

Assignees

@hanno-becker hanno-becker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Signing: Combine mld_poly_make_hint and mld_pack_sig_h_poly

4 participants

@mkannwischer @oqs-bot @hanno-becker @jakemas