Refactor mld_polymat_permute_bitrev_to_custom#770
Closed
Conversation
rod-chapman
force-pushed
the
cbmc-native2
branch
from
78014be to
335cbf4
Compare
mkannwischer
force-pushed
the
cbmc-native2
branch
3 times, most recently
from
9ad5704 to
2319ec4
Compare
(polymat_permute_bitrev_to_custom_native) - Unlike previous commit: 52df632, this commit want to remove the temporary workaround, directly prove polymat_permute_bitrev_custom on top of native API. Co-authored-by: Matthias J. Kannwischer <matthias@kannwischer.eu> Signed-off-by: willieyz <willie.zhao@chelpis.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
changed the title
Contributor
|
No longer needed as it was eliminated in #1019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: CBMC: Add proofs atop of native functions #350
Based on: CBMC: Add proofs for native backend functions #768
Resolves CBMC: Refactor
mld_polymat_permute_bitrev_to_customand prove monolithically #847The CBMC proof for
mld_poly_permute_bitrev_to_customincluded here causes the ML-DSA-44 proof to blow up. We are investigating and addressing this issue in this pull request.Error log
Update(Dec 8): Thanks for help from @mkannwischer and @rod-chapman , now had an issue report: Proof/SMT explosion for simple nested loop over 2D array diffblue/cbmc#8796
Update(Dec 31): we decide to resolve issue CBMC: Add proofs atop of native functions #350 with pr CBMC: Prove mld_polymat_permute_bitrev_to_custom on top of native API #820.