fix(spaces): mobile board could not scroll down, and chat never appeared - #63
Merged
Conversation
Two reports from a phone, one root cause each. The Kanban board was overflow-x-auto overflow-y-hidden. On desktop that is right — columns are full-height and scroll internally. On mobile a column is taller than the screen, so everything below the fold was unreachable: you could scroll sideways but not down. Below md the board now scrolls vertically and columns size to their content, with the inner per-column scroll kept for md+ so mobile does not get a nested scroll region that traps the gesture. The space chat was a flex sibling that split the screen. Competing with the tab content for height on a tall board, it was pushed past the bottom edge and simply never appeared when toggled. On mobile it is now a fixed bottom sheet at z-40, above the tab bar at z-30 — 'over content' is the point — with pb-mobile-nav so the composer clears the bar and gives the space back when the keyboard opens. Desktop keeps the resizable in-flow column unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reports from a phone, one root cause each.
The Kanban board was
overflow-x-auto overflow-y-hidden. Right on desktop, where columns are full-height and scroll internally. On mobile a column is taller than the screen, so everything below the fold was unreachable — you could scroll sideways but not down. Belowmdthe board now scrolls vertically and columns size to their content; the inner per-column scroll is kept formd+so mobile doesn't get a nested scroll region that traps the gesture.The space chat was a flex sibling that split the screen, not an overlay. Competing with the tab content for height on a tall board, it was pushed past the bottom edge and simply never appeared when toggled. It's now a fixed bottom sheet at
z-40, above the tab bar atz-30— 'over content' being the whole point — withpb-mobile-navso the composer clears the bar and gives the space back when the keyboard opens. Desktop keeps the resizable in-flow column unchanged.Already built and deployed to the live box for testing.