Performance: compat shallowDiffers

[romgrk]

This util is used to compare props. Props are more likely (I'm guessing) to have the same shape from one render to the next. Therefore, it's better to check first if the values differ than if the keys differ.

This benchmark compares 20-keys objects with the same shape for the same-values and different-values cases.

Benchmark: https://github.com/romgrk/js-benchmark/blob/master/benchmarks/object-shallow-compare.js

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -1% - +0% (-5.93ms - +4.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +0% (-0.02ms - +0.05ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -2% - +1% (-1.60ms - +0.96ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -4% - +3% (-0.60ms - +0.51ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +3% (-0.53ms - +1.73ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.07ms)
  ^{preact-local vs preact-main}
• todo: faster ✔ 0% - 2% (0.04ms - 0.72ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -4% - +3% (-1.42ms - +1.13ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -2% - +2% (-0.10ms - +0.10ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -2% - +5% (-0.02ms - +0.05ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	879.58ms - 886.89ms	-	unsure 🔍 -1% - +0% -5.93ms - +4.00ms
preact-main	880.85ms - 887.55ms	unsure 🔍 -0% - +1% -4.00ms - +5.93ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.05ms - 19.05ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	19.05ms - 19.05ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.55ms - 16.59ms	-	unsure 🔍 -0% - +0% -0.02ms - +0.05ms
preact-main	16.53ms - 16.58ms	unsure 🔍 -0% - +0% -0.05ms - +0.02ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.55ms - 1.56ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-main	1.55ms - 1.56ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	64.38ms - 66.20ms	-	unsure 🔍 -2% - +1% -1.60ms - +0.96ms
preact-main	64.71ms - 66.51ms	unsure 🔍 -1% - +2% -0.96ms - +1.60ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	5.08ms - 5.22ms	-	unsure 🔍 -2% - +2% -0.10ms - +0.10ms
preact-main	5.08ms - 5.22ms	unsure 🔍 -2% - +2% -0.10ms - +0.10ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.20ms - 17.04ms	-	unsure 🔍 -4% - +3% -0.60ms - +0.51ms
preact-main	16.31ms - 17.02ms	unsure 🔍 -3% - +4% -0.51ms - +0.60ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.73ms - 3.74ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	3.73ms - 3.74ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	60.54ms - 62.07ms	-	unsure 🔍 -1% - +3% -0.53ms - +1.73ms
preact-main	59.88ms - 61.53ms	unsure 🔍 -3% - +1% -1.73ms - +0.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.00ms - 3.00ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	3.00ms - 3.00ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.06ms - 28.83ms	-	unsure 🔍 -3% - +1% -0.84ms - +0.30ms
preact-main	28.29ms - 29.14ms	unsure 🔍 -1% - +3% -0.30ms - +0.84ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.79ms - 34.78ms	-	unsure 🔍 -1% - +3% -0.45ms - +0.96ms
preact-main	33.53ms - 34.53ms	unsure 🔍 -3% - +1% -0.96ms - +0.45ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.36ms - 35.41ms	-	unsure 🔍 -3% - +1% -1.18ms - +0.30ms
preact-main	34.80ms - 35.86ms	unsure 🔍 -1% - +3% -0.30ms - +1.18ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.38ms - 27.89ms	-	unsure 🔍 -1% - +2% -0.27ms - +0.50ms
preact-main	27.23ms - 27.81ms	unsure 🔍 -2% - +1% -0.50ms - +0.27ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.65ms - 26.23ms	-	unsure 🔍 -3% - +6% -0.66ms - +1.54ms
preact-main	24.23ms - 25.76ms	unsure 🔍 -6% - +3% -1.54ms - +0.66ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.05ms - 22.66ms	-	unsure 🔍 -1% - +3% -0.26ms - +0.74ms
preact-main	21.72ms - 22.51ms	unsure 🔍 -3% - +1% -0.74ms - +0.26ms	-

text-update

• Browser: chrome-headless
• Sample size: 80
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.79ms - 1.90ms	-	unsure 🔍 -5% - +4% -0.09ms - +0.07ms
preact-main	1.79ms - 1.91ms	unsure 🔍 -4% - +5% -0.07ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.99ms - 1.05ms	-	unsure 🔍 -2% - +5% -0.02ms - +0.05ms
preact-main	0.99ms - 1.03ms	unsure 🔍 -5% - +2% -0.05ms - +0.02ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.65ms - 30.91ms	-	faster ✔ 0% - 2% 0.04ms - 0.72ms
preact-main	30.84ms - 31.48ms	slower ❌ 0% - 2% 0.04ms - 0.72ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.26ms - 1.26ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.26ms - 1.26ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5529

• Commit: 6ff68b7

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.70ms - 36.36ms	-	unsure 🔍 -4% - +3% -1.42ms - +1.13ms
preact-main	34.70ms - 36.64ms	unsure 🔍 -3% - +4% -1.13ms - +1.42ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.98ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	2.96ms - 2.98ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

_{tachometer-reporter-action v2 for CI}

[romgrk]

Ping, and you can close the PR if it's not going to be merged.

[rschristian]

Thanks for the ping, sorry this PR slipped our notice.

I believe this is only used for memo() & PureComponent, both of which are pretty uncommon nowadays. Did you run into any detectable issue with one of them to end up looking at this? Just curious; I think it's a fine change & I agree changing values will occur more often.

Just needs a rebase, and also, main is targeting the upcoming v11, v10.x is the branch for the v10 release line. You can mirror this to v10 if you want or not

[romgrk]

I didn't notice any issue, I was just reading the codebase to understand the differences with React and noticed it. It's more of a lint. I'm happy with just targetting main.

[coveralls]

coverage: 98.528%. remained the same — romgrk:perf-shallow-compare into preactjs:main