Conversation
prefix
The `/ox keys` command previously listed all PGP keys known to the system,
displaying a massive number of keys of which the vast majority cannot be
used for OX.
According to XEP-0373: OpenPGP for XMPP, the User ID of the key must correspond
to the JID of the user as an 'xmpp' URI ("xmpp:juliet@example.org").
General PGP keys in the user's keyring that lack this prefix are invalid for OX.
* Introduce internal helper `_ox_gpg_get_keys()` to retrieve keys
containing an 'xmpp:' UID prefix.
* Create new `ox_gpg_list_keys()` that runs a second-pass query
specifically looking for corresponding private keys in the secret
keyring.
* Update `/ox keys` to call `ox_gpg_list_keys()` instead of the generic
`p_gpg_list_keys()`.
Fixes: #2177
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Member
Author
|
@mdosch please test :) |
jubalh
changed the title
/ox keys to those matching xmpp:/ox keys to those matching xmpp prefix
Contributor
|
Works well, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/ox keyscommand previously listed all PGP keys known to the system, displaying a massive number of keys of which the vast majority cannot be used for OX.According to XEP-0373: OpenPGP for XMPP, the User ID of the key must correspond to the JID of the user as an 'xmpp' URI ("xmpp:juliet@example.org"). General PGP keys in the user's keyring that lack this prefix are invalid for OX.
_ox_gpg_get_keys()to retrieve keys containing an 'xmpp:' UID prefix.ox_gpg_list_keys()that runs a second-pass query specifically looking for corresponding private keys in the secret keyring./ox keysto callox_gpg_list_keys()instead of the genericp_gpg_list_keys().Fixes: #2177