Conversation
Avoid overwriting the stored last message ID in MUCs when an outgoing message is a correction. In 1:1 chats, we prevent overwriting the stored last_msg_id when sending a correction. In MUCs, last_msg_id was unconditionally overwritten with the ID of the correction message itself. XEP-0308: "If a message is corrected multiple times, every subsequent correction must reference the ID of the original message, not the ID of the previous correction." Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Change behavior to update the stored "last message" buffer with the corrected text. Previously, the buffer purposely preserved the original message text, causing subsequent corrections to autocomplete back to the original message. With this change, subsequent corrections will autocomplete to and edit the most recently corrected text instead. This was requested by users in the MUC. And seems to be what other clients do as well. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid overwriting the stored last message ID in MUCs when an outgoing message is a correction.
In 1:1 chats, we prevent overwriting the stored last_msg_id when sending a correction.
In MUCs, last_msg_id was unconditionally overwritten with the ID of the correction message itself.
XEP-0308:
"If a message is corrected multiple times, every subsequent correction must reference the ID of the original message, not the ID of the previous correction."