feat: add Brave and Tavily MCP presets - #1976
Merged
Merged
Conversation
Made-with: Proma
Made-with: Proma
Review follow-ups for the search MCP presets: - Required MCP tool discovery now enters a 2-minute failure cooldown after a failed handshake: subsequent turns fall back to the 500ms optional bootstrap race while the reconnect continues in background, and a successful reconnect exits the cooldown immediately. This keeps the preset goal (a freshly connected MCP is usable in the next turn) without letting an offline server or dead credential tax every message with the full connect/listTools timeout. - Strip a user-pasted auth prefix (e.g. "Bearer ") before saving a credential so a Tavily key cannot be stored as "Bearer Bearer ...". - Bind stdio API-key credentials to the command+args they were saved for, and refuse to inject the key when the server config no longer matches (e.g. mcp.json edited on disk to point the same server name at a different command). - Restore the catalog preset equality test and add behavior tests for the cooldown (hanging server timeout, same-port recovery), replacing the removed source-string smoke tests. Performance: main-process only; one O(1) map lookup per required server per turn, no new timers/subscriptions/IPC listeners; renderer change is a one-shot input normalization on save. Made-with: Proma
Made-with: Proma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance
Validation
Made with Proma · GitHub