fix(tool-approval-guard): narrow the shipped defaults (v0.3.1) - #18
Merged
Conversation
veeqtoh
force-pushed
the
fix/tool-approval-guard-defaults
branch
from
August 6, 2026 18:58
7c657e7 to
7081bb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.0 defaults blocked legitimate tool calls.
entitieswas derived fromPIIRedactorDefaults, which includesemail, and the default action isblockso any agent with a mail, SMS or HTTP tool had its normal operations rejected.scan_injection: truehad the same problem: prose written for a human reader matches the patterns ("You are now subscribed to weekly updates.").With the shipped defaults, 4 of 5 ordinary operations blocked.
Changes
entitiesdefaults tocredit_card,api_key,bearer_token. The others remain supported, opt-in.scan_injectiondefaults tofalse.ToolApprovalGuardDefaultsno longer derives fromPIIRedactorDefaults. An architecture test pins them apart.action: 'log'is not observe-only unlessblock_entitiesis empty.Every change loosens a default, so nothing that worked on v0.3.0 stops working.
block_entitiesis unchanged.Verification
Test passing.