ci: pin the remaining workflow actions to commit SHAs - #12
Merged
Conversation
publish-images.yml and release.yml were pinned because they hold write credentials; ci.yml stayed on moving tags under the release-track deferral. Same action, same SHA, every workflow — the SHAs are the ones the pinned workflows already use, so this closes the split without introducing a second resolution of anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-images.ymlandrelease.ymlwere SHA-pinned because they hold writecredentials;
ci.ymlstayed on moving tags under the release-track deferral.Closing that split (spec rule
release.pin.action-sha): the same action nowresolves to the same SHA in every workflow of this repo —
actions/checkout@v411d5960a…# v4.4.0 (same SHA release.yml uses)actions/setup-node@v449933ea5…# v4.4.0 (same)pnpm/action-setup@v4b906affc…# v4.3.0 (same)No Dependabot exists here, so pins move only by deliberate commit. The rule
requires immutability, not automated freshness.
Test plan
Mechanical ref swap — each SHA is exactly what the moving tag resolves to
today, and identical to the SHAs the pinned workflows already run. CI on this
PR exercises all three swapped actions.