fix: report SUBSCRIBE and PUBLISH that never leave the client - #582
Open
johnnyh1975 wants to merge 7 commits into
Open
fix: report SUBSCRIBE and PUBLISH that never leave the client#582johnnyh1975 wants to merge 7 commits into
johnnyh1975 wants to merge 7 commits into
Conversation
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
subscribe() and publish() discarded paho's return code. When the client
is not connected paho returns MQTT_ERR_NO_CONN and no packet is sent at
all, but both calls returned as though they had succeeded.
The observable result is a subscription that reports nothing for the
rest of its life, or a command that never reaches the robot, in both
cases with nothing anywhere saying so. publish("cmd", ...) is the path
every command takes.
Check the return code and log it. No signature change and no protocol
change: the check works at any QoS.
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
subscribe() and publish() discarded paho's return code. When the client
is not connected paho returns MQTT_ERR_NO_CONN and no packet is sent at
all, but both calls returned as though they had succeeded.
The observable result is a subscription that reports nothing for the
rest of its life, or a command that never reaches the robot, in both
cases with nothing anywhere saying so. publish("cmd", ...) is the path
every command takes.
Check the return code and log it. No signature change and no protocol
change: the check works at any QoS.
Signed-off-by: johnnyh1975 <jean-christoph@5heyne.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscribe() and publish() discarded paho's return code. When the client
is not connected paho returns MQTT_ERR_NO_CONN and no packet is sent at
all, but both calls returned as though they had succeeded.
The observable result is a subscription that reports nothing for the
rest of its life, or a command that never reaches the robot, in both
cases with nothing anywhere saying so. publish("cmd", ...) is the path
every command takes.
Check the return code and log it. No signature change and no protocol
change: the check works at any QoS.