Feature/update stackup and rf - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the project to v1.2.4 and updates both the acquisition PCB deliverables (stackup/RF-related layout outputs) and the nRF52 firmware to improve streaming reliability and IMU/I2C behavior.
Changes:
- Update versioning and changelogs for v1.2.4 across the repo, firmware, and acquisition PCB.
- Refresh acquisition PCB fabrication outputs (Gerbers, NC drill, pick-place) and project output configuration (incl. keep-out layer output).
- Improve nRF52 firmware robustness: stop SPI bursts in hardware via PPI, reset frame timers deterministically, set BLE TX power per SoC, and harden/accelerate IIS2DH I2C reads.
Reviewed changes
Copilot reviewed 29 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Version bump to v1.2.4 in top-level README. |
| hw/wulpus_acquisition_pcb/wulpus_acq_pcb.PrjPcb | Updates Altium project outputs/variant metadata and generated document list (incl. new keep-out output). |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Pick Place/Pick Place for PCB1(Fabrication_ready).txt | Updated pick/place output reflecting RF/layout changes and new antenna/matching network. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/NC Drill/PCB1.LDP | Updated NC drill layer-pair export metadata. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/NC Drill/PCB1.DRR | Updated NC drill report (tool counts/time). |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/NC Drill/PCB1-Plated.TXT | Updated plated drill coordinates/tool formatting. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/NC Drill/PCB1-NonPlated.TXT | Updated non-plated drill coordinates/tool formatting. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.REP | Updated Gerber generation report (layer ordering, dcodes, keep-out, overlays). |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GTS | Updated top soldermask Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GTP | Updated top paste Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GTO | Updated top overlay Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GM | Updated profile/mechanical Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GKO | Adds keep-out Gerber output. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GBS | Updated bottom soldermask Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GBP | Updated bottom paste Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.GBO | Updated bottom overlay Gerber. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.EXTREP | Updated Gerber extension report (incl. keep-out layer). |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1.apr | Updated aperture report for new Gerber set. |
| hw/wulpus_acquisition_pcb/docs/fabrication_files/Gerber/PCB1-macro.APR_LIB | Updated macro aperture library (rounded-rect macro IDs). |
| hw/wulpus_acquisition_pcb/CHANGELOG.md | Adds acquisition PCB v1.2.4 changelog entry (RF/layout + antenna change). |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/us_spi.c | Stops SPI burst via PPI on counter CC0 (reduces dependency on interrupt latency). |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/us_ble.c | Sets BLE TX power on connect with SoC-specific max power. |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/pca10040/s132/config/sdk_config.h | Raises GPIOTE/TIMER IRQ priorities; enables TWI/TWI1 for IIS2DH I2C. |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/main.c | Clears timers at frame start to ensure deterministic burst timing/counts. |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/iis2dh.h | Adds IIS2DH auto-increment and CTRL_REG4 bit definitions. |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/iis2dh.c | Improves I2C robustness, uses burst read at 400 kHz, fixes accel block placement in frame. |
| fw/nrf52/ble_peripheral/US_probe_nRF52_firmware/CHANGELOG.md | Adds firmware v1.2.4 changelog describing streaming reliability fixes and I2C changes. |
| CHANGELOG.md | Adds top-level v1.2.4 summary entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1,19 +1,20 @@ | |||
| Altium Designer Pick and Place Locations | |||
| C:\Users\serge\Documents\repos\wulpus_dev\hw\wulpus_acquisition_pcb\Project Outputs for wulpus_acq_pcb\Pick Place\Pick Place for PCB1(Fabrication_ready).txt | |||
| C:\Users\s-fre\Github\wulpus\hw\wulpus_acquisition_pcb\Project Outputs for wulpus_acq_pcb\Pick Place\Pick Place for PCB1(Fabrication_ready).txt | |||
| @@ -1,3 +1,3 @@ | |||
| Layer Pairs Export File for PCB: C:\Users\serge\Documents\repos\wulpus_dev\hw\wulpus_acquisition_pcb\PCB1.PcbDoc | |||
| Layer Pairs Export File for PCB: C:\Users\s-fre\Github\wulpus\hw\wulpus_acquisition_pcb\PCB1.PcbDoc | |||
| ### Fixed | ||
|
|
||
| - Acquisition PCB layout changes to improve RF performance | ||
| - Firmware improvements on nRF52 to improved reliability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.