Skip to content

fix: AWS deployment system#373

Merged
cherriechang merged 93 commits into
mainfrom
fix/aws-deployment
May 11, 2026
Merged

fix: AWS deployment system#373
cherriechang merged 93 commits into
mainfrom
fix/aws-deployment

Conversation

@cherriechang

@cherriechang cherriechang commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

by migrating to AWS SDK

jkhartshorne and others added 30 commits November 17, 2023 17:03
…d against null distributionList.Items (line 671);
check for .yalc/ and yalc.lock, and create these if needed
Fix error catching with execFile and docker builds
…race condition that caused undefined/missing data in DB
@becky-gilbert

Copy link
Copy Markdown
Contributor

While reviewing/testing this, I came across a few other issues that I've fixed here (sorry - in the future they will go in separate, smaller PRs!).

Here's a summary of the changes since my last comment:

  • Merged branch that fixes several worker issues (fix: experiment workers not set up in pushkin-cli currently #376) and fixed merge conflicts.
  • Merged branch that fixes error in pushkin prep when no experiments are installed (check for .yalc/ and yalc.lock, and create these if needed #406)
  • Await execFile commands in try/catch blocks to catch/handle async docker errors.
  • Update the worker index.js files for non-basic experiment templates to match the basic template.
  • Update SSL check logic so that this only sets SSL: true for RDS endpoints (no SSL for any non-RDS host names, not just localhost)
  • Await logTransaction in pushkin worker to prevent race condition that causes data-saving errors
  • Fix a TypeError that can occur in the catch block for docker database set-up errors. This TypeError was masking the actual error that should be reported to the user.
  • Udpate ensureCleanState in pushkin prep so that it handles orphaned pushkin DB volumes. (Previously it would detect containers and then remove everything, but the container check misses the case when containers were removed but volumes remained - this would cause pushkin prep to fail in the same way that it would before with existing containers).
  • Add/update changesets (not actually sure if this is necessary because the changesets should describe fixes relative to the last release, and some of these changes might be just fixing bugs within this branch...).

@cherriechang if you're happy with all of this then we're ready to merge! Otherwise let me know if you have feedback/questions - happy to make changes.

@becky-gilbert becky-gilbert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cherriechang
cherriechang merged commit 4a34b62 into main May 11, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration Address deprecated dependencies pushkin-cli Relates to the CLI

Projects

None yet

4 participants