fix: AWS deployment system#373
Merged
Merged
Conversation
…ed builtFrontEnd var in deployFrontEnd()
…d against null distributionList.Items (line 671);
…ss hanging operations with timeout;
…me is set in one place
…(leftover from a different solution that was removed in favor of SSL auto-detection)
…ue, and fix merge conflicts
fix: experiment workers not set up in pushkin-cli currently
check for .yalc/ and yalc.lock, and create these if needed
… re network timeout errors
Fix error catching with execFile and docker builds
…es failing compare-to-basic tests
…non-localhost docker service names
…race condition that caused undefined/missing data in DB
…t or any other Docker service names
Contributor
|
While reviewing/testing this, I came across a few other issues that I've fixed here (sorry - in the future they will go in separate, smaller PRs!). Here's a summary of the changes since my last comment:
@cherriechang if you're happy with all of this then we're ready to merge! Otherwise let me know if you have feedback/questions - happy to make changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by migrating to AWS SDK