dynamic shape arg#4233
Open
apbose wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_shared_dynamic_dim.py 2026-05-05 04:54:37.448873+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_shared_dynamic_dim.py 2026-05-05 04:55:00.216122+00:00
@@ -14,10 +14,11 @@
caller supply a shared ``Dim`` directly to ``torch_tensorrt.compile`` --
mirroring the ``torch.export.export(dynamic_shapes=...)`` signature -- so the
shared-batch case compiles end to end without the caller having to pre-export
the module themselves.
"""
+
import unittest
import pytest
import torch
import torch.nn as nn64bcdc4 to
adffa87
Compare
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_shared_dynamic_dim.py 2026-06-04 17:31:18.741538+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/models/test_shared_dynamic_dim.py 2026-06-04 17:31:43.478755+00:00
@@ -13,10 +13,11 @@
name; the same name across inputs is exported as a single shared ``Dim``. All
the dynamic-shape intent lives on the ``Input`` objects -- no separate
``dynamic_shapes`` argument and no ``torch.export`` knowledge required at the
call site.
"""
+
import unittest
import pytest
import torch
import torch.nn as nnadffa87 to
ae1ce2f
Compare
Collaborator
Author
|
@narendasan are you suggesting something like this? B and S are the named tuples torch_tensorrt.compile( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.