Skip to content

Add change_modulus and change_q - #532

Merged
jnsiemer merged 6 commits into
devfrom
set_modulus
Aug 7, 2026
Merged

Add change_modulus and change_q#532
jnsiemer merged 6 commits into
devfrom
set_modulus

Conversation

@jnsiemer

@jnsiemer jnsiemer commented May 6, 2026

Copy link
Copy Markdown
Member

Description

This PR implements...

  • change_modulus
  • change_q

for all non-NTT Zq datatypes.

Testing

  • I added basic working examples (possibly in doc-comment)
  • I added tests for large (pointer representation) values
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide

@jnsiemer
jnsiemer requested a review from Marvin-Beckmann May 6, 2026 10:36
@jnsiemer jnsiemer self-assigned this May 6, 2026

@Marvin-Beckmann Marvin-Beckmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current implementation is not working as intended after the mod is changed, see the respective comment

Comment thread src/integer_mod_q/modulus_polynomial_ring_zq/set.rs
Comment thread src/integer_mod_q/modulus_polynomial_ring_zq/set.rs
@jnsiemer
jnsiemer requested a review from Marvin-Beckmann May 6, 2026 12:22
@jnsiemer
jnsiemer merged commit deeac92 into dev Aug 7, 2026
2 checks passed
@jnsiemer
jnsiemer deleted the set_modulus branch August 7, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants