FROMLIST: usb: dwc3: Update nominal max votes for qcom usb

[akakum-qualcomm]

Increase nominal max votes to improve DDR performance and USB audio use case handling.

Currently, Bandwidth vote for max nominal value is set to 2500, requiring DDR to run at 1GHz under normal load.

DDR is allowed to run under nominal range at 1.5GHz, which is consistent across all targets. However, with the current nominal Increase nominal max votes to improve DDR performance and USB audio use case handling.

Currently, Bandwidth vote for max nominal value is set to 2500, requiring DDR to run at 1GHz under normal load.

DDR is allowed to run under nominal range at 1.5GHz, which is consistent across all targets. However, with the current nominal vote, glitches are observed during multiple audio use cases over USB. Update the nominal vote to allow DDR to run more
efficiently, enabling simultaneous multiple USB audio use cases without glitches.

With the existing vote, throughput is around 124MB/s. The updated nominal value increases throughput to 134MB/s.

With Updated Nominal value, we are seeing
Enhanced performance and stability for multiple USB audio use cases and improved overall system efficiency with higher throughput.

CRs-Fixed: 4548487
qli-2.0 GA Critical Fix

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #680 — validate-patch

PR: #680

Verdict	Issues	Detailed Report
❌	15	Full report

Final Summary

1. Lore link present: No — PENDING prefix; no Link: tag found in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — PENDING prefix indicates patch not yet posted to mailing list
4. PR present in qcom-next: Not checked — patch validation scope only

Recommendation: Author should:

• Fix duplicate paragraphs in commit message
• Post patch to linux-usb@vger.kernel.org and Cc: dwc3 maintainers
• Add Link: tag after upstream discussion
• Include testing details (platforms tested, regression testing)
• Wait for maintainer feedback before merging to vendor tree

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #680 - PENDING: usb: dwc3: Update nominal max votes for qcom usb
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	PENDING prefix indicates not yet upstream
Body preserves rationale	❌	Duplicate paragraphs; poor structure
Fixes tag present/correct	N/A	Not a fix; performance enhancement
Authorship preserved	✅	Author: Akash Kumar akakum@qti.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/usb/dwc3/dwc3-qcom.c	⚠️	Changes bandwidth values without upstream discussion

Issues

Critical: Commit Message Quality

• Lines 8-17 are duplicated verbatim (lines 8-12 repeat at lines 13-17)
• Inconsistent capitalization: "Increase nominal max votes" appears twice
• Missing proper paragraph breaks and flow
• The commit message should be rewritten to remove duplication

Structural Issues:

• First paragraph duplicated: "Increase nominal max votes to improve DDR performance..." appears twice
• Second paragraph duplicated: "Currently, Bandwidth vote for max nominal value is set to 2500..." appears twice
• Awkward phrasing: "With Updated Nominal value, we are seeing Enhanced performance" (unnecessary capitalization)

Technical Concerns:

• No Link: tag pointing to lore discussion or upstream submission
• PENDING prefix suggests this is not yet posted upstream
• Significant bandwidth changes (2500→5500 MBps, 0→40 avg, 40→80 peak) without upstream review
• No mention of testing methodology, affected platforms, or potential regressions
• Missing context: which Qualcomm SoCs are affected? All targets or specific ones?

Code Changes:

• USB_MEMORY_PEAK_SS_BW: 2500 → 5500 MBps (120% increase)
• APPS_USB_AVG_BW: 0 → 40 (new non-zero average)
• APPS_USB_PEAK_BW: 40 → 80 MBps (100% increase)

These are substantial changes to power/performance parameters that should undergo upstream review.

Verdict

Reject — Commit message contains duplicate paragraphs and lacks upstream discussion. The patch must be cleaned up, posted to linux-usb@vger.kernel.org for review, and include a Link: tag before merging.

Final Summary

1. Lore link present: No — PENDING prefix; no Link: tag found in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Not upstream — PENDING prefix indicates patch not yet posted to mailing list
4. PR present in qcom-next: Not checked — patch validation scope only

Recommendation: Author should:

• Fix duplicate paragraphs in commit message
• Post patch to linux-usb@vger.kernel.org and Cc: dwc3 maintainers
• Add Link: tag after upstream discussion
• Include testing details (platforms tested, regression testing)
• Wait for maintainer feedback before merging to vendor tree

[qlijarvis]

PR #680 — checker-log-analyzer

PR: #680
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27226105308

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #680 - PENDING: usb: dwc3: Update nominal max votes for qcom usb
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27226105308

Checker	Result	Summary
checkpatch	✅	No style issues detected
dt-binding-check	⏭️	Skipped - no DT binding changes
dtb-check	⏭️	Skipped - no devicetree changes
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	Subject prefix violation
tag-check	N/A	Not applicable for qcom-6.18.y
qcom-next-check	N/A	Not applicable for qcom-6.18.y

---

❌ check-patch-compliance

Root cause: Commit subject uses PENDING: prefix, which is not a recognized upstream or downstream prefix.

Failure details:

Checking commit: PENDING: usb: dwc3: Update nominal max votes for qcom usb
Commit summary does not start with a required prefix
##[error]Process completed with exit code 1.

Fix: Replace PENDING: with an appropriate prefix:

1. If this is a downstream-only change (not intended for upstream):

   • Use QCOM: prefix
   • Example: QCOM: usb: dwc3: Update nominal max votes for qcom usb

2. If this will be submitted upstream:

   • Use FROMLIST: prefix (if already posted to a mailing list)
   • Use UPSTREAM: prefix (if already merged upstream)
   • Example: FROMLIST: usb: dwc3: Update nominal max votes for qcom usb

3. If this is backported from upstream:

   • Use BACKPORT: prefix
   • Example: BACKPORT: usb: dwc3: Update nominal max votes for qcom usb

Reproduce locally:

cd kernel
git log --oneline -1 7166122e92cf
# Check if subject starts with UPSTREAM:/FROMLIST:/BACKPORT:/QCOM:

Additional notes:

• The patch itself is clean (checkpatch passed)
• No functional issues detected
• Only the commit message prefix needs correction

---

Verdict

1 blocker to fix: Update commit subject to use a valid prefix (QCOM:, FROMLIST:, UPSTREAM:, or BACKPORT:) instead of PENDING:.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4548487 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4548487

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qcomlnxci]

Test jobs on 7166122

• Job 124009 on lemans-evk
• Job 124013 on monaco-evk
• Job 124014 on qcs615-ride
• Job 124015 on qcs6490-rb3gen2
• Job 124010 on qcs8300-ride
• Job 124011 on qcs9100-ride-r3
• Job 124012 on x1e80100-crd

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	◻️	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	◻️	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	◻️	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	◻️	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	◻️	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️

[qswat-orbit-external]

Merge Check Failed: CR Not Eligible for Merge

CR 4548487 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4548487
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

[qcomlnxci]

Test jobs on 7166122

• Job 124009 on lemans-evk
• Job 124374 on monaco-evk
• Job 124014 on qcs615-ride
• Job 124015 on qcs6490-rb3gen2
• Job 124010 on qcs8300-ride
• Job 124011 on qcs9100-ride-r3
• Job 124012 on x1e80100-crd

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	✅ Pass	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️

[shashim-quic]

PENDING: usb: dwc3: Update nominal max votes for qcom usb

send it to upstream and bring as FROMLIST.

[akakum-qualcomm]

PENDING: usb: dwc3: Update nominal max votes for qcom usb

send it to upstream and bring as FROMLIST.

Done.