Skip to content

hamoa: Enable CDSP cooling in staging dtso#685

Merged
sgaud-quic merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
dmantre:hamoa-staging
Jun 11, 2026
Merged

hamoa: Enable CDSP cooling in staging dtso#685
sgaud-quic merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
dmantre:hamoa-staging

Conversation

@dmantre

@dmantre dmantre commented Jun 10, 2026

Copy link
Copy Markdown

Unlike the CPU, the CDSP does not throttle its speed automatically when it reaches high temperatures in hamoa.

Set up CDSP cooling by throttling the cdsp when it reaches 105°C.

CRs-Fixed: 4551445

Unlike the CPU, the CDSP does not throttle its speed automatically
when it reaches high temperatures in hamoa.

Set up CDSP cooling by throttling the cdsp when it reaches 105°C.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
@dmantre dmantre requested review from a team, knaveen-qc, quicAspratap and trsoni June 10, 2026 06:55
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@gauravkohli1 gauravkohli1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qlijarvis

Copy link
Copy Markdown

PR #685 — validate-patch

PR: #685

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patch not yet posted to upstream mailing lists
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Not upstream — PENDING: prefix confirms this is pre-submission work
  4. PR present in qcom-next: Not checked — PENDING: patches are typically staged before upstream submission

Note: The PENDING: prefix is appropriate for patches in development or awaiting upstream submission. The patch targets a staging DTSO file (hamoa-staging.dtso), which suggests this is Qualcomm-internal staging work that may be prepared for future upstream submission once the platform support is ready.

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #685 - PENDING: arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
Upstream commit: N/A (PENDING: prefix indicates not yet posted upstream)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix; not yet upstream
Body preserves rationale Clear explanation of thermal throttling need
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Dipa Ramesh Mantre dipa.mantre@oss.qualcomm.com
Backport note (if applicable) N/A Original work, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/hamoa-staging.dtso Adds CDSP thermal cooling configuration for 4 NSP thermal zones

Commit Message Quality

  • Subject: Clear and descriptive, follows arm64 DTS convention
  • Body: Explains the problem (CDSP doesn't auto-throttle) and solution (throttle at 105°C)
  • Technical details: Adds QMI cooling device and maps it to thermal_nsp0-3 zones
  • Signed-off-by: Present and correct

Technical Content Review

  • Adds #include <dt-bindings/thermal/thermal.h> for THERMAL_NO_LIMIT macro
  • Creates QMI cooling device under &remoteproc_cdsp with proper binding
  • Configures 4 thermal zones (nsp0-3) with identical trip points at 105°C
  • Uses standard passive cooling with 5°C hysteresis
  • Follows devicetree binding conventions for thermal management

Verdict

Merge as-is. This is a well-formed PENDING patch for internal staging DTS overlay with clear rationale and correct devicetree syntax.

Final Summary

  1. Lore link present: No — PENDING: prefix indicates patch not yet posted to upstream mailing lists
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Not upstream — PENDING: prefix confirms this is pre-submission work
  4. PR present in qcom-next: Not checked — PENDING: patches are typically staged before upstream submission

Note: The PENDING: prefix is appropriate for patches in development or awaiting upstream submission. The patch targets a staging DTSO file (hamoa-staging.dtso), which suggests this is Qualcomm-internal staging work that may be prepared for future upstream submission once the platform support is ready.

@qlijarvis

Copy link
Copy Markdown

PR #685 — checker-log-analyzer

PR: #685
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27259134590

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - Invalid commit prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #685 - PENDING: arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27259134590

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - Invalid commit prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

❌ check-patch-compliance

Root cause: Commit subject starts with "PENDING:" which is not an allowed prefix for Qualcomm Linux kernel commits.

Failure details:

2026-06-10T07:16:03.9879478Z Checking commit: PENDING: arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
2026-06-10T07:16:03.9895454Z Commit summary does not start with a required prefix
2026-06-10T07:16:03.9896047Z Leaving /opt/actions-runner/_work/kernel-config/kernel-config/kernel
2026-06-10T07:16:03.9911707Z ##[error]Process completed with exit code 1.

Fix: Update the commit subject to use one of the allowed prefixes:

  • UPSTREAM: - for patches already merged in mainline Linux
  • FROMLIST: - for patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - for patches backported from a newer kernel version
  • Or use no prefix if this is Qualcomm-specific work (just start with the subsystem)

For this patch adding CDSP cooling to hamoa-staging.dtso, the appropriate fix depends on the patch status:

  1. If this is Qualcomm-specific staging work, remove "PENDING:" and use:
    arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
    
  2. If this patch was posted upstream, use:
    FROMLIST: arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
    
  3. If already merged upstream, use:
    UPSTREAM: arm64: dts: qcom: hamoa: Enable CDSP cooling in staging dtso
    

Reproduce locally:

git log --oneline -1 baab91c1a24b09ebc90abb904bd80dcb7396e6ef
# Check if subject starts with UPSTREAM:, FROMLIST:, BACKPORT:, or a valid subsystem prefix

To fix, amend the commit:

git commit --amend
# Edit the subject line to remove "PENDING:" and use appropriate prefix

Verdict

1 blocker to fix: Remove the "PENDING:" prefix from the commit subject and replace it with an appropriate prefix (UPSTREAM:/FROMLIST:/BACKPORT:) or remove it entirely if this is Qualcomm-specific work. All other checkers passed successfully.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@dmantre

dmantre commented Jun 11, 2026

Copy link
Copy Markdown
Author

This is qli-2.0 GA Critical Fix

@sgaud-quic sgaud-quic merged commit 693fd51 into qualcomm-linux:qcom-6.18.y Jun 11, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants