Build directory search lists once instead of parsing strings#290
Open
quic-parihar wants to merge 3 commits into
Open
Build directory search lists once instead of parsing strings#290quic-parihar wants to merge 3 commits into
quic-parihar wants to merge 3 commits into
Conversation
quic-parihar
force-pushed
the
path_list_update
branch
3 times, most recently
from
337158e to
89d3060
Compare
quic-parihar
force-pushed
the
path_list_update
branch
from
89d3060 to
431f7d8
Compare
ekanshibu
requested changes
Feb 18, 2026
quic-parihar
force-pushed
the
path_list_update
branch
2 times, most recently
from
fc06976 to
7df7879
Compare
Contributor
|
Fixes: #270 |
Chennak-quic
requested changes
Mar 31, 2026
Chennak-quic
requested changes
Mar 31, 2026
quic-parihar
force-pushed
the
path_list_update
branch
from
7df7879 to
197266f
Compare
quic-parihar
force-pushed
the
path_list_update
branch
from
197266f to
6e48d3c
Compare
ekanshibu
reviewed
Apr 15, 2026
quic-parihar
force-pushed
the
path_list_update
branch
2 times, most recently
from
7c2494c to
e15ca41
Compare
Convert ADSP library search paths from concatenated env/config strings into persistent QList-backed directory lists built at init time. This removes repeated parsing of ';' delimited path strings on every fopen call and avoids reconstructing combined search paths for each lookup. The new logic initializes global directory list during apps_std_init(). Paths from environment variables and config files are parsed once and stored as individual nodes. All file lookup APIs are updated to walk this list directly instead of reparsing a flat string. This improves efficiency, reduces string and handling complexity. Legacy behavior is preserved for custom environment variables that do not match the standard ADSP_* and DSP_* path names. Also update open_shell() to use the global list instead of constructing a temporary ";" delimited directory list. Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>
Previously, while parsing DSP library paths from the config YAML, we only prefixed CONFIG_BASE_DIR (/usr/share/qcom) to the first path. This caused subsequent relative paths to be left unresolved, leading to incomplete search coverage and potential library load failures. Update the parsing logic to: - Iterate over all semicolon-separated entries in dsp_lib_paths. - Prefix CONFIG_BASE_DIR to every relative path Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>
This patch removes Windows-style CRLF line terminators and converts the file to Unix-style LF line endings. No functional changes are made; this only normalizes formatting to match the project's coding conventions. Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>
quic-parihar
force-pushed
the
path_list_update
branch
from
e15ca41 to
09464bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert ADSP library and AVS search paths from concatenated env/config strings into persistent QList-backed directory lists built at init time. This removes repeated parsing of ';'-delimited path strings on every fopen call and avoids reconstructing combined search paths for each lookup.
The new logic initializes two global directory lists (library and AVS) during apps_std_init(). Paths from environment variables and config files are parsed once and stored as individual nodes. All file lookup APIs are updated to walk these lists directly instead of reparsing a flat string.
This improves efficiency, reduces string and handling complexity. Legacy behavior is preserved for custom environment variables that do not match the standard ADSP_* and DSP_* path names.
Also update open_shell() to use the global list instead of constructing a temporary ";"-delimited directory list.