Skip to content

fix: resolve all failing tests across monorepo packages#14

Open
stooit wants to merge 1 commit into
mainfrom
quantcode/job-e2e-tier3-2384-1779727925
Open

fix: resolve all failing tests across monorepo packages#14
stooit wants to merge 1 commit into
mainfrom
quantcode/job-e2e-tier3-2384-1779727925

Conversation

@stooit
Copy link
Copy Markdown
Contributor

@stooit stooit commented May 25, 2026

Summary

  • Renamed hook: Export useDebounce as useSearchDebounce from @e2e/utils and fix the import in apps/web/src/lib/api.ts (was importing removed useThrottle)
  • Button accessibility: Pass aria-label prop through to the rendered button element
  • DataTable stale closure: Use functional state updater in sort handler to avoid capturing stale state
  • Date formatting: Switch to non-zero-padded day format (d/MM/yyyy style via en-AU locale options)
  • DOM test environment: Configure happy-dom preload in root bunfig.toml so UI tests have access to document/window

Verification

All 13 tests pass (bun test). TypeScript compiles cleanly (npx tsc --noEmit — only expected bun:test module resolution warnings remain since it's a runtime-only module).

Assumptions

  • The bun:test TS2307 errors are expected/acceptable since bun:test is not a real npm package
  • The date format expectation of "1/03/2024" (non-zero-padded day) is the intended behavior
  • No test files were modified
  • No new dependencies were added

- Fix renamed hook: export useDebounce as useSearchDebounce from @e2e/utils
- Fix api.ts import to use useDebounce instead of removed useThrottle
- Add aria-label passthrough to Button component for accessibility
- Fix DataTable stale closure bug in sort handler using functional updater
- Fix date formatting to use non-zero-padded day format (en-AU locale)
- Configure happy-dom preload in root bunfig.toml for DOM test environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant