fix: resolve all failing tests across monorepo packages#2
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix useSearchDebounce export in apps/web by importing useDebounce from @e2e/utils - Add aria-label to Button component for accessibility test - Fix stale closure bug in DataTable sort handler using functional state update - Fix date formatting to use day without leading zero (d/MM/yyyy) - Configure root bunfig.toml preload for happy-dom global registration - Update tsconfig to include proper paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchDebounceexport inapps/web/src/lib/api.ts— the utility hook was renamed touseDebounceinpackages/utilsbut the old import name was still usedaria-labelattribute topackages/ui/src/components/Button/Button.tsxfor accessibility compliancepackages/ui/src/components/DataTable/DataTable.tsx— sort handler now uses functional state update to avoid capturing stale statepackages/utils/src/format/date.ts— day no longer zero-padded (usesd/MM/yyyyformat)bunfig.tomlnow preloads happy-dom setup so DOM globals are available in all test filesVerification
All 13 tests pass and
tsc --noEmitreports zero type errors.Constraints followed