fix: resolve 4 cross-package bugs causing test failures#3
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook: re-export useDebounce as useSearchDebounce in api.ts - Add happy-dom test environment config for UI package - Forward aria-label prop in Button component for accessibility - Fix stale closure in DataTable sort handler using functional state update - Use non-padded day format (d/MM/yyyy) in date formatting utility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests across the monorepo by resolving 4 cross-package bugs:
apps/web): TheuseSearchDebounceexport was broken becauseapi.tsimporteduseThrottleinstead ofuseDebouncefrom@e2e/utils. Fixed the import and re-export alias.packages/ui): UI component tests failed with "document is not defined". Added happy-dom environment configuration inbunfig.tomlwith the existing setup file.packages/ui): TheButtoncomponent didn't forwardaria-labelfor icon-only buttons. Added the prop to the interface and element.packages/ui):DataTablesort handler captured stalesortDirectionstate. Fixed by using a functional state update.packages/utils):formatDateused zero-padded day (dd/MM/yyyy) but tests expected non-padded (d/MM/yyyy).Verification
All 13 tests pass, 0 type errors with
bun test && npx tsc --noEmit.Assumptions