fix: resolve all failing tests across monorepo packages#4
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix useSearchDebounce export by re-exporting useDebounce with correct alias in apps/web - Add happy-dom test environment config for UI component tests - Pass aria-label prop through Button component for accessibility - Fix stale closure in DataTable sort handler using functional state update - Fix date formatting to use non-zero-padded day (d/MM/yyyy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchDebounceexport: TheuseDebouncehook inpackages/utilswas being imported asuseThrottleinapps/web. Updated the import and re-export alias touseSearchDebounceas expected by tests.happy-domtest environment configuration inbunfig.tomlforpackages/uicomponent tests.Buttoncomponent passes througharia-labelprop for icon-only buttons.prev => ...) in the sort direction handler to avoid stale closure bug.d/MM/yyyy) matching test expectations.Verification
All 13 tests pass (
bun test), andnpx tsc --noEmitshows no source code type errors (only expectedbun:testmodule resolution in test files).Assumptions
bun:testmodule resolution errors in test files are acceptable since they are inherent to bun's test runner and test files cannot be modified.happy-domwas already available innode_modules(no new dependencies added).