fix: resolve 4 cross-package bugs causing test failures#5
Open
stooit wants to merge 1 commit into
Open
Conversation
- Rename useThrottle import to useDebounce in apps/web/src/lib/api.ts (hook was renamed in packages/utils) - Fix stale closure bug in Button component by using callback ref pattern - Add role="table" accessibility attribute to DataTable component - Fix date formatting to use en-AU locale with correct format string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests in this TypeScript monorepo by resolving 4 cross-package bugs:
apps/web/src/lib/api.ts): ChangeduseThrottle→useDebounceimport from@e2e/utils— the hook was renamed inpackages/utilsbut the consumer still used the old namepackages/ui/src/components/Button/Button.tsx): Fixed stale closure in click handler caught by controlled re-render test — used callback ref pattern to always read current propspackages/ui/src/components/DataTable/DataTable.tsx): Addedrole="table"attribute required by the DataTable testpackages/utils/src/format/date.ts): Fixed date formatter to useen-AUlocale with correct format stringVerification
bun test— 0 failures)npx tsc --noEmit— only expectedbun:testmodule resolution in test files)Constraints followed