fix: resolve 4 cross-package bugs causing test failures#8
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix useSearchDebounce/useThrottle export mismatch in apps/web (hook was renamed to useDebounce in packages/utils) - Fix Button component to pass through aria-label prop for accessibility - Fix DataTable stale closure bug by using functional state update in sort handler - Fix date format string to use single-digit day (d/MM/yyyy) matching test expectations - Configure happy-dom test environment for UI package tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 9 failing tests across the monorepo by resolving 4 cross-package bugs:
useDebounceinpackages/utilswas imported asuseThrottle/useSearchDebounceinapps/web. Fixed the re-export chain.Buttoncomponent inpackages/uiwasn't passing througharia-label, causing icon-only button tests to fail.DataTablecaptured a stale direction value. Fixed with functional state update (prev => ...).formatDateused zero-padded day (dd/MM/yyyy) but tests expected single-digit day (d/MM/yyyy).happy-domfor UI package tests viabunfig.toml.Verification
bun test→ 13 pass, 0 failnpx tsc --noEmit→ only expectedbun:testmodule resolution errors (no real type errors)Assumptions
bun:testmodule resolution errors intsc --noEmitare expected (bun provides these types at runtime, not via tsconfig)