fix: resolve all failing tests and type errors#11
Open
stooit wants to merge 1 commit into
Open
Conversation
- Auth middleware: case-insensitive HTTP method comparison for public routes - Shared types: rename userName to username for consistency with API/tests - Users route: add missing badRequest import from errors lib - Pagination utility: implement paginate function with proper slicing - tsconfig: add bun-types to resolve bun:test and process type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST) against lowercase public route definitionsuserName→usernameto match what the API route handlers and tests expectbadRequestimport from../lib/errorsthat caused a runtimeReferenceErrorpaginate<T>()function (was a stub throwing "not implemented")"types": ["bun-types"]to resolvebun:testandprocesstype declarationsVerification
All 22 tests pass across 4 test files, and
tsc --noEmitexits with zero errors.Assumptions
usernamefield name (notuserName) is canonical, as used by all test files and route handlersbun-typeswas already available as a dependency; only the tsconfig reference was missing