fix: resolve all test failures and type errors across api and shared packages#13
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#13stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity: change 'post' to 'POST' in public methods list - Rename User type field from 'userName' to 'username' for consistency - Import badRequest helper in users route handler - Implement pagination utility (paginate function) per test expectations - Fix process.env reference in auth.ts to avoid @types/node dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"but Hono provides the method as uppercase"POST", causing POST requests to incorrectly require authentication.userNametousernamein the sharedUsertype to match what routes and tests expect.badRequesthelper so the route handler compiles and returns proper 400 responses.paginate()function inpackages/shared/src/utils/pagination.tsto satisfy existing test expectations.process.envin auth middleware source with a globalThis cast to avoid requiring@types/node.Verification
All 22 tests pass (
bun test) andtsc --noEmitreports zero source-file errors.Assumptions
processreference in test files is acceptable (Bun runtime provides it; type errors in test files are cosmetic since@types/bunis not installed).