fix: resolve all failing tests in API and shared packages#16
Open
stooit wants to merge 1 commit into
Open
Conversation
- Auth middleware: fix case-sensitivity bug in HTTP method comparison - Users route: add missing badRequest import/helper - Shared types: rename userName to username for consistency with tests - Pagination utility: implement paginate function (was stub)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/api/src/middleware/auth.ts): Fixed case-sensitivity bug wherepublicMethodsused lowercase"post"but HTTP methods arrive uppercase ("POST"). Changed to uppercase to match correctly.packages/api/src/routes/users.ts): Added missingbadRequesthelper that was referenced but never defined/imported, causing runtime failures.packages/shared/src/types.ts): RenameduserNamefield tousernameto match what the API route handlers and tests expect.packages/shared/src/utils/pagination.ts): Implemented thepaginatefunction which was previously a stub throwing "not implemented".Verification
All 22 tests pass (
bun test). TypeScript type-check (npx tsc --noEmit) shows only environment-specific errors (bun:testmodule resolution andprocessglobal — expected without@types/bun).Assumptions
bun:testandprocessare pre-existing environment configuration issues, not source code bugs