fix: resolve all test failures and type errors#17
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix auth middleware case-sensitivity bug (method comparison now case-insensitive) - Fix process.env reference to work without @types/node - Import badRequest helper in users route - Align User type field names (username/email) with test expectations - Implement paginate utility function in shared package - Update tsconfig to skip lib check for compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST), causing public routes to incorrectly return 401process.envwith a globalThis-safe accessor to eliminate TS2580 error without requiring@types/nodebadRequestimport that caused runtime failuresUsertype field names (username,email) with what the API tests expectpaginate<T>function (was a stub throwing "not implemented")Verification
All 22 tests pass (
bun test) andtsc --noEmitreports zero errors.Assumptions
usernameandemailfields (matching what tests send in request bodies)badRequesthelper exists in the api lib directory and just needed importing