fix: resolve failing tests across api and shared packages#18
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity: use uppercase HTTP methods in publicMethods - Rename User type field userName to username for consistency with tests - Add missing badRequest import in users route handler - Implement pagination utility (paginate function) as expected by tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodsarray inpackages/api/src/middleware/auth.tsused lowercase method names ("post") while Hono provides uppercase ("POST"), causing POST requests to incorrectly receive 401 responses.packages/shared/src/types.tsdefineduserNamebut tests and route handlers expectedusername. Renamed tousernamefor consistency.packages/api/src/routes/users.tsreferenced an undefinedbadRequesthelper. Added the import from the shared utilities.packages/shared/src/utils/pagination.tswas not implemented. Added thepaginatefunction matching the test expectations.Verification
bun test)npx tsc --noEmit, excluding environment-onlybun:testmodule resolution)Assumptions