fix: resolve all failing tests and type errors#19
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug (POST method matching) - Add missing badRequest import in users route handler - Fix field name mismatch between User type and route handler - Implement pagination utility function - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodsused lowercase"post"but HTTP methods arrive as uppercase"POST", causing authenticated routes to reject valid public requestsbadRequestimport and fixed field name mismatch between request body (username) andUsertype (name)paginate<T>()function that was previously a stub throwing "not implemented"bun-typestotsconfig.jsoncompilerOptions.typesto resolvebun:testmodule andprocessglobal type errorsVerification
All 22 tests pass, 0 type errors:
Files Changed
packages/api/src/middleware/auth.ts— uppercase method in publicMethods, removed bareprocessusagepackages/api/src/routes/users.ts— added import, mappedusername→namepackages/shared/src/types.ts— ensured User type field consistencypackages/shared/src/utils/pagination.ts— implemented paginate functiontsconfig.json— added bun-types for type resolution