fix: resolve all test failures and type errors#20
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix auth middleware case-sensitivity: use 'POST' (uppercase) in public methods list - Fix User type field name: rename userName to username for consistency with tests - Add missing badRequest import in users route handler - Implement pagination utility (paginate function) in shared package - Replace process.env with Bun.env in auth middleware to fix type error - Update tsconfig to include node types for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'post'but Hono provides uppercase HTTP methods ('POST'), causing all POST requests to require authentication unexpectedly.Usertype useduserName(camelCase) but all consumers and tests expectedusername(lowercase). Renamed the type field.badRequesthelper was used but not imported — added the import.paginate()function inpackages/shared/src/utils/pagination.tswas a stub. Implemented to slice arrays with offset/limit and return metadata.process.envwithBun.envin auth middleware (this is a Bun project) and updated tsconfig for proper type resolution.Verification
bun test— 22 tests pass, 0 failuresnpx tsc --noEmit— zero type errorsAssumptions