fix: resolve all test failures and type errors#21
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix auth middleware: correct HTTP method case comparison (POST vs post) and use Bun.env - Fix shared User type: rename userName to username for consistency - Fix users route: add missing badRequest helper and correct field references - Implement pagination utility to satisfy test expectations - Update tsconfig to include bun-types for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"→"POST") and replacedprocess.envwithBun.envto resolve type errorsuserName→usernamein theUsertype to match usage across both packagesbadRequesthelper function and corrected field referencestsconfig.jsonto includebun-typesfor proper type resolutionVerification
All 22 tests pass across 4 test files, and
tsc --noEmitreports zero type errors.Assumptions
Bun.envinstead ofprocess.envin source files since this is a Bun runtime project