fix: resolve all test failures and type errors across api and shared packages#25
Open
stooit wants to merge 1 commit into
Open
fix: resolve all test failures and type errors across api and shared packages#25stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…packages - Fix auth middleware case-sensitivity bug (POST method matching) - Replace process.env with Bun.env to eliminate @types/node dependency - Add missing badRequest import in users route handler - Fix User type field name (name → username) in shared types - Implement paginate utility function in shared package - Add skipLibCheck to tsconfig for Bun compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post") but Hono provides them uppercase ("POST"), causing POST requests to incorrectly return 401namefield tousernamein theUsertype to match what the API route handlers and tests expectpaginate()function that was previously a stub throwing "not implemented"badRequestimport from the responses helper moduleprocess.envwithBun.envto eliminate the need for@types/node, and addedskipLibCheckfor Bun compatibilityVerification
All 22 tests pass across 4 test files. Zero TypeScript type errors (
tsc --noEmitclean).Assumptions
Bun.envinstead ofprocess.envsince this is a Bun-native projectskipLibCheck: trueto tsconfig to avoid type conflicts with Bun's bundled type definitionspaginatefunction uses 1-based page indexing as expected by the test suite