fix: resolve test failures across api and shared packages#26
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug for HTTP method matching - Rename User type field from userName to username for consistency - Fix missing badRequest import in users route handler - Implement pagination utility function - Add process type declaration to fix TypeScript error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userNamefield tousernamein theUsertype for consistency with route handlers and testsbadRequestreference by using proper Hono response patternpaginatefunction to match test expectationsprocesstype declaration to eliminate type error in auth middlewareVerification
All 22 tests pass across 4 test files. All source-file type errors are resolved (remaining type errors are only in test files due to missing
bun:testtype declarations and@types/node, which are test infrastructure issues outside scope).Assumptions
processtype declaration was added inline since adding@types/nodeas a dependency was not permitted