fix: resolve all failing tests across api and shared packages#27
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity: HTTP methods are uppercase per RFC 7231 - Add missing badRequest import in users route handler - Rename User.userName to User.username for consistency with tests - Implement paginate utility (was a stub throwing 'not implemented') - Add skipLibCheck to tsconfig.json to resolve process type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodsarray — changed"post"to"POST"since Hono provides uppercase methods per RFC 7231badRequestto the import from../lib/errorsin users route handleruserName→usernamein the sharedUsertype to match test expectationspaginatefunction (was a stub throwing "not implemented") — returns{ data, page, pageSize, total, totalPages }skipLibCheck: trueto resolveprocesstype errors without adding new dependenciesVerification
All 22 tests pass (
bun test). The only remainingtsc --noEmiterrors arebun:testmodule declarations in test files (Bun built-in, not resolvable without modifying test files or adding dependencies).Assumptions
bun:testTypeScript errors in test files are acceptable (Bun runtime resolves them)