fix: resolve all test failures and type errors#3
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix auth middleware case-sensitivity bug (compare HTTP methods case-insensitively) - Rename User type field userName → username for consistency with route handlers - Implement paginate() utility function in shared package - Fix missing import in users route (use createError instead of non-existent badRequest) - Add bun-types to tsconfig to resolve type errors in source files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.toUpperCase()so POST requests are correctly recognized regardless of casinguserName→usernameon theUsertype to match what route handlers and tests expectpaginate()function that was previously a stub throwing "not implemented"badRequest→createError) and aligned field names with the correctedUsertypebun-typestotsconfig.jsoncompilerOptions.typesto resolveprocessand other Node/Bun global type errorsVerification
bun test→ 22 tests pass, 0 failuresnpx tsc --noEmit→ 0 type errorsAssumptions
PaginatedResponse<T>type already existed inpackages/shared/src/types.tswith fields:data,page,pageSize,total,totalPagesbun-typeswas already available innode_modules(no new dependency added)