fix: resolve all test failures and type errors#4
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix User type field name: userName → username (shared/types.ts) - Implement paginate() utility with proper slicing and metadata (shared/utils/pagination.ts) - Fix auth middleware case-sensitivity: normalize HTTP method to uppercase (api/middleware/auth.ts) - Add missing badRequest import and fix field names in users route (api/routes/users.ts) - Add bun-types to tsconfig to resolve process.env type errors (tsconfig.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userName→usernameinpackages/shared/src/types.tsto match what tests and route handlers expectpaginate()inpackages/shared/src/utils/pagination.ts— slices items by page/size and returns proper metadata (totalItems, totalPages, hasNext, hasPrev)packages/api/src/middleware/auth.tsso POST/PUT/DELETE requests are properly authenticatedbadRequestimport from../lib/errorsinpackages/api/src/routes/users.tsbun-typestotsconfig.jsoncompilerOptions to resolveprocess.envtype errorsVerification
bun test— 22 tests pass, 0 failuresnpx tsc --noEmit— zero type errorsAssumptions
bun-typeswas already available innode_modules(dev dependency of bun)