fix: resolve all failing tests and type errors#5
Open
stooit wants to merge 1 commit into
Open
Conversation
- Implement paginate() utility in shared package - Fix User type field name: userName -> username - Fix auth middleware case-sensitivity bug for HTTP methods - Add missing badRequest import in users route handler - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 22 failing tests and eliminates all TypeScript type errors across both packages.
Changes
Pagination utility (
packages/shared/src/utils/pagination.ts): Implemented thepaginate()function that was previously a stub throwing "not implemented". Correctly slices items by page/size and returnsPaginatedResponse<T>with total, totalPages, and page metadata.User type field name (
packages/shared/src/types.ts): RenameduserName→usernameto match the field name used in route handlers and tests.Auth middleware case-sensitivity (
packages/api/src/middleware/auth.ts): Fixed HTTP method comparison to be case-insensitive, so public routes likePOST /usersare correctly excluded from auth checks.Missing import (
packages/api/src/routes/users.ts): Added missingbadRequestimport from the response helpers module.TypeScript config (
tsconfig.json): Addedbun-typesto compiler options for proper Bun global type resolution.Verification
Assumptions
bun-typespackage was already available in node_modules