fix: resolve all test failures and type errors#8
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix User type field name: userName → username (shared/types.ts) - Implement paginate() utility with proper slicing and metadata (shared/utils/pagination.ts) - Fix auth middleware case-sensitivity: normalize HTTP method to uppercase (api/middleware/auth.ts) - Fix missing import and field name usage in users route handler (api/routes/users.ts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (22 pass, 0 fail) and eliminates actionable type errors across both
apiandsharedpackages.Changes
packages/shared/src/types.ts— RenameduserNamefield tousernamein theUsertype to match test expectations and API contractpackages/shared/src/utils/pagination.ts— Implemented thepaginate()utility (was a stub throwing "not implemented") with proper array slicing and pagination metadatapackages/api/src/middleware/auth.ts— Fixed case-sensitivity bug in HTTP method check by normalizing to uppercase before comparisonpackages/api/src/routes/users.ts— Fixed missing import (badRequest→ correct export name) and aligned field names with the correctedUsertypeVerification
bun test→ 22 pass, 0 fail, 37 expect() callsnpx tsc --noEmit→ only ambient type errors remain (bun:testmodule,processglobal) which are expected without@types/node/@types/buninstalledAssumptions
processandbun:testare acceptable since the constraint says "do not add new dependencies"