fix: resolve all failing tests across api and shared packages#9
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug (method comparison now matches actual HTTP methods) - Rename User type field from userName to username for consistency with tests - Add missing badRequest import and fix field references in users route - Implement pagination utility to satisfy test expectations - Fix process.env reference in auth.ts to satisfy tsc without @types/node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"but actual requests use uppercase"POST", causing POST requests to/usersto incorrectly return 401userNamefield tousernamein theUsertype to match test expectations and route handler usagebadRequesthelper (inline 400 response) and updated field references fromuserNametousernamepaginatefunction to satisfy test expectations (accepts array + page/pageSize, returns paginated slice with metadata)process.envreference in auth middleware to compile without@types/nodeVerification
All 22 tests pass (
bun test). No type errors in source files (npx tsc --noEmit— only test-file errors forbun:testmodule remain, which are expected in Bun runtime).Assumptions
bun:testandprocesstsc errors in test files are acceptable since tests run in Bun which provides these globals