fix: resolve all 16 failing tests across 5 utility modules#165
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount to handle multiple spaces, implement truncate - date-utils: use Math.round for relative day calculation (off-by-one fix) - task-manager: implement remove, update, and sortBy methods - validator: allow long TLDs in email, allow ports in URL validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Infinity)wordCountto handle multiple consecutive spaces; implementedtruncatewith word-boundary logicMath.floortoMath.roundfor relative day calculation (fixes off-by-one at 36 hours)remove,update, andsortBymethodsTest Results
All 60 tests pass (previously 44 pass / 16 fail).
Assumptions
sortBy("priority")uses high > medium > low orderingsortBy("createdAt")uses oldest-first (ascending) orderingtruncateprefers word-boundary breaks but falls back to hard truncation when no word boundary fits within the limit