fix: resolve all failing tests in utility library#166
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw Error on division by zero instead of returning Infinity - string-utils: fix wordCount to handle consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: use Math.round in formatRelative for correct day rounding - validator: allow long TLDs in isEmail; allow ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error("Division by zero")when dividing by zero instead of returningInfinitywordCountto split on/\s+/(handles consecutive spaces); implementtruncatewith word-boundary logicremove,update, andsortBymethodsMath.roundinformatRelativeso 36 hours correctly displays as "2 days ago".museum) inisEmail; allow port numbers inisUrlTest Results
All 60 tests pass across 5 test files (0 failures).
Assumptions
truncatetruncates at word boundaries and appends "..." within the maxLength budgetsortBy("priority")orders high > medium > lowsortBy("createdAt")orders oldest firstError(not a custom error class)