fix: resolve all 16 failing tests across utility library#173
Open
stooit wants to merge 1 commit into
Open
Conversation
…anager, date-utils, and validator - calculator.ts: throw Error on division by zero instead of returning Infinity - string-utils.ts: fix wordCount to split on /\s+/ for multiple spaces; implement truncate with word-boundary logic - task-manager.ts: implement remove, update, and sortBy methods - date-utils.ts: use Math.round instead of Math.floor for day calculation in formatRelative - validator.ts: allow TLDs of 2+ chars in isEmail; allow ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/calculator.tsdividethrowsError("Division by zero")when divisor is 0src/string-utils.tswordCountsplits on/\s+/to handle multiple consecutive spaces; implementedtruncatewith word-boundary logicsrc/task-manager.tsremove,update, andsortBymethodssrc/date-utils.tsMath.floortoMath.roundinformatRelativefor correct day roundingsrc/validator.tsisEmail; added optional port support inisUrlAssumptions
truncateuses word-boundary splitting where "..." counts towardmaxLengthsortBy("priority")sorts high > medium > lowsortBy("createdAt")sorts oldest firstError(not a custom error class)